refactor(env): eliminate redundant find_system_tool call in doctor

Thread the system node path from check_shim_mode() into
check_current_resolution() instead of scanning PATH twice.

Also add debug_assert in JsRuntime::from_system() to catch
empty binary filenames from malformed paths.

Author: fengmk2

crates/vite_global_cli/src/commands/env/doctor.rs

@@ -114,7 +114,7 @@ pub async fn execute(cwd: AbsolutePathBuf) -> Result<ExitStatus, Error> {
 
     // Section: Configuration
     print_section("Configuration");
-    let shim_mode = check_shim_mode().await;
+    let (shim_mode, system_node_path) = check_shim_mode().await;
 
     // Check env sourcing: IDE-relevant profiles first, then all shell profiles
     #[cfg(not(windows))]
@@ -128,7 +128,7 @@ pub async fn execute(cwd: AbsolutePathBuf) -> Result<ExitStatus, Error> {
 
     // Section: Version Resolution
     print_section("Version Resolution");
-    check_current_resolution(&cwd, shim_mode).await;
+    check_current_resolution(&cwd, shim_mode, system_node_path).await;
 
     // Section: Conflicts (conditional)
     check_conflicts();
@@ -247,8 +247,8 @@ fn shim_filename(tool: &str) -> String {
     }
 }
 
-/// Check and display shim mode. Returns the current mode for use by other checks.
-async fn check_shim_mode() -> ShimMode {
+/// Check and display shim mode. Returns the mode and any found system node path.
+async fn check_shim_mode() -> (ShimMode, Option<AbsolutePathBuf>) {
     let config = match load_config().await {
         Ok(c) => c,
         Err(e) => {
@@ -257,10 +257,12 @@ async fn check_shim_mode() -> ShimMode {
                 "Node.js mode",
                 &format!("config error: {e}").yellow().to_string(),
             );
-            return ShimMode::default();
+            return (ShimMode::default(), None);
         }
     };
 
+    let mut system_node_path = None;
+
     match config.shim_mode {
         ShimMode::Managed => {
             print_check(&output::CHECK.green().to_string(), "Node.js mode", "managed");
@@ -275,6 +277,7 @@ async fn check_shim_mode() -> ShimMode {
             // Check if system Node.js is available
             if let Some(system_node) = shim::find_system_tool("node") {
                 print_check(" ", "System Node.js", &system_node.as_path().display().to_string());
+                system_node_path = Some(system_node);
             } else {
                 print_check(
                     &output::WARN_SIGN.yellow().to_string(),
@@ -285,7 +288,7 @@ async fn check_shim_mode() -> ShimMode {
         }
     }
 
-    config.shim_mode
+    (config.shim_mode, system_node_path)
 }
 
 /// Check profile files for env sourcing and classify where it was found.
@@ -585,12 +588,16 @@ fn print_ide_setup_guidance(bin_dir: &vite_path::AbsolutePath) {
 }
 
 /// Check current directory version resolution.
-async fn check_current_resolution(cwd: &AbsolutePathBuf, shim_mode: ShimMode) {
+async fn check_current_resolution(
+    cwd: &AbsolutePathBuf,
+    shim_mode: ShimMode,
+    system_node_path: Option<AbsolutePathBuf>,
+) {
     print_check(" ", "Directory", &cwd.as_path().display().to_string());
 
-    // In system-first mode, show system Node.js version instead of managed resolution
+    // In system-first mode, show system Node.js info instead of managed resolution
     if shim_mode == ShimMode::SystemFirst {
-        if let Some(system_node) = shim::find_system_tool("node") {
+        if let Some(system_node) = system_node_path {
             let version = get_node_version(&system_node).await;
             print_check(" ", "Source", "system PATH");
             print_check(" ", "Version", &version.bright_green().to_string());

crates/vite_js_runtime/src/runtime.rs

@@ -79,6 +79,7 @@ impl JsRuntime {
         let binary_filename: Str = Str::from(
             binary_path.as_path().file_name().unwrap_or_default().to_string_lossy().as_ref(),
         );
+        debug_assert!(!binary_filename.is_empty(), "binary_path has no filename: {binary_path:?}");
         Self {
             runtime_type,
             version: "system".into(),