Skip to content

Commit a40a2df

Browse files
committed
fix(ci): move ca-certificates test to Alpine E2E job
Move the TLS negative test from test-standalone-install.yml to the "Run E2E in Alpine container" step in ci.yml, which is the proper place to test vp runtime behavior on Alpine.
1 parent c1ea842 commit a40a2df

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

.github/workflows/ci.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -638,6 +638,17 @@ jobs:
638638
which npm
639639
node --version
640640
641+
# Verify vp requires ca-certificates for TLS (rustls-platform-verifier reads OS cert store).
642+
# Remove the cert bundle, then try to download a Node.js version not yet cached.
643+
rm -f /etc/ssl/certs/ca-certificates.crt
644+
if vp env run --node 23 -- node -e 'process.exit(0)' 2>&1; then
645+
echo 'Error: vp should fail without ca-certificates'
646+
exit 1
647+
fi
648+
echo 'Confirmed: vp HTTPS fails without ca-certificates (expected)'
649+
# Restore certs for remaining tests
650+
apk fix --no-cache ca-certificates-bundle
651+
641652
# Test global package install
642653
vp install -g typescript
643654
tsc --version

.github/workflows/test-standalone-install.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -254,17 +254,6 @@ jobs:
254254
vp env doctor
255255
vp env run --node 24 -- node -p \"process.versions\"
256256
257-
# Verify vp requires ca-certificates for TLS (rustls-platform-verifier reads OS cert store).
258-
# Remove the cert bundle, then try to download a Node.js version not yet cached.
259-
rm -f /etc/ssl/certs/ca-certificates.crt
260-
if vp env run --node 23 -- node -e 'process.exit(0)' 2>&1; then
261-
echo 'Error: vp should fail without ca-certificates'
262-
exit 1
263-
fi
264-
echo 'Confirmed: vp HTTPS fails without ca-certificates (expected)'
265-
# Restore certs for remaining tests
266-
apk fix --no-cache ca-certificates-bundle
267-
268257
# Test create command
269258
vp create vite --no-interactive --no-agent -- hello --no-interactive -t vanilla
270259
cd hello && vp run build && vp --version

0 commit comments

Comments
 (0)