Skip to content

Commit ac85c38

Browse files
committed
refactor(build): consolidate build chain into pnpm build script
The justfile's build recipe and the root package.json's build script had drifted: the justfile knew it needed to build rolldown's native binding, rolldown's JS, and vite's types before the @voidzero-dev/* chain, while package.json's build only ran the @voidzero-dev/* + vite-plus step. That meant pnpm bootstrap-cli (which calls pnpm build) silently produced an incomplete tree on fresh checkouts — packages/ core/dist/vite/node/index.d.ts wouldn't exist, and vp check then failed with TS7016 on every @voidzero-dev/vite-plus-core import. Move the upstream prerequisites into the pnpm build script and have the justfile recipe just call pnpm build, so the build sequence has a single source of truth. CI is unaffected: bootstrap-cli:ci runs only pnpm install-global-cli, and the per-target build-upstream action keeps its own chain (it skips build-binding:release because the binding is pulled from npm, and runs build-ts instead of build because NAPI bindings are built and cached as a separate step).
1 parent 8172f08 commit ac85c38

2 files changed

Lines changed: 2 additions & 8 deletions

File tree

justfile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,7 @@ _fix_symlinks:
4242

4343
build:
4444
pnpm install
45-
pnpm --filter rolldown build-binding:release
46-
pnpm --filter rolldown build-node
47-
pnpm --filter vite build-types
48-
pnpm --filter=@voidzero-dev/vite-plus-core build
49-
pnpm --filter=@voidzero-dev/vite-plus-test build
50-
pnpm --filter=@voidzero-dev/vite-plus-prompts build
51-
pnpm --filter=vite-plus build
45+
pnpm build
5246

5347
ready:
5448
git diff --exit-code --quiet

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"license": "MIT",
55
"type": "module",
66
"scripts": {
7-
"build": "pnpm -F @voidzero-dev/* -F vite-plus build",
7+
"build": "pnpm --filter rolldown build-binding:release && pnpm --filter rolldown build-node && pnpm --filter vite build-types && pnpm -F @voidzero-dev/* -F vite-plus build",
88
"bootstrap-cli": "pnpm build && cargo build -p vite_global_cli -p vite_trampoline --release && pnpm install-global-cli",
99
"bootstrap-cli:ci": "pnpm install-global-cli",
1010
"install-global-cli": "tool install-global-cli",

0 commit comments

Comments
 (0)