fix(migration): re-pin vite-plus in force-override mode, fix lint/format/typo

PR #1588 CI failures:
- Force-override mode (VP_FORCE_MIGRATE=1, set by test-vp-create.yml and
  ecosystem-ci) now re-pins any pre-existing vite-plus range to the local
  tgz path in monorepo workspace packages. Without this, pnpm reads the
  published vite-plus@0.1.21 metadata to resolve transitive deps including
  @voidzero-dev/vite-plus-test@0.1.21, which shadowed upstream vitest@4.1.5
  at runtime and broke vp create monorepo tests.
- typos CI: rename yarn-PnP to yarn Plug'n'Play (Pn→On false positive).
- vp check: format packages/cli/build.ts shim-generation block.
- Rename __dirname in install-failure-guard.spec.ts to satisfy
  eslint(no-underscore-dangle).

Author: Brooooooklyn

packages/cli/build.ts

@@ -367,7 +367,10 @@ async function syncTestPackageExports() {
       //   ./test/browser/providers/<short> → e.g. ./test/browser/providers/playwright
       const pkgShortName = pkg.startsWith('@vitest/') ? pkg.slice('@vitest/'.length) : pkg;
       const surfaces = [
-        { cliPath: `./test/${pkgShortName}${providerSubPath}`, baseName: `${pkgShortName}${providerSubPath}` },
+        {
+          cliPath: `./test/${pkgShortName}${providerSubPath}`,
+          baseName: `${pkgShortName}${providerSubPath}`,
+        },
         {
           cliPath: `./test/browser/providers/${short}${providerSubPath}`,
           baseName: `browser/providers/${short}${providerSubPath}`,

packages/cli/src/migration/__tests__/install-failure-guard.spec.ts

@@ -4,8 +4,8 @@ import { fileURLToPath } from 'node:url';
 
 import { describe, expect, it } from 'vitest';
 
-const __dirname = path.dirname(fileURLToPath(import.meta.url));
-const binPath = path.resolve(__dirname, '..', 'bin.ts');
+const here = path.dirname(fileURLToPath(import.meta.url));
+const binPath = path.resolve(here, '..', 'bin.ts');
 
 /**
  * `runViteInstall` returns `{ status: 'failed', exitCode }` (it does not throw)

packages/cli/src/migration/migrator.ts

@@ -125,7 +125,9 @@ function isLegacyWrapperSpec(value: string | undefined): boolean {
  * is dropped entirely. Returns true iff any entry was changed.
  */
 function pruneLegacyWrapperAliases(record: Record<string, string> | undefined): boolean {
-  if (!record) return false;
+  if (!record) {
+    return false;
+  }
   let mutated = false;
   for (const key of Object.keys(record)) {
     if (isLegacyWrapperSpec(record[key])) {
@@ -1477,7 +1479,9 @@ function getYamlMapScalarStringValue(map: unknown, key: string): string | undefi
 }
 
 function pruneYamlMapLegacyWrapperAliases(map: unknown): void {
-  if (!(map instanceof YAMLMap)) return;
+  if (!(map instanceof YAMLMap)) {
+    return;
+  }
   const stale: Array<{ key: Scalar<string>; fallback: string | undefined }> = [];
   for (const item of map.items) {
     const value = item.value instanceof Scalar ? item.value.value : undefined;
@@ -1835,6 +1839,19 @@ export function rewritePackageJson(
       }
     }
   }
+  // Force-override mode (ecosystem CI / `vp create` E2E) must re-pin any
+  // pre-existing `vite-plus` range to the local tgz. Otherwise pnpm reads the
+  // published vite-plus metadata for transitive dep resolution (e.g.
+  // `@voidzero-dev/vite-plus-test`) even though the override replaces the
+  // vite-plus package itself, dragging the stale wrapper into node_modules.
+  if (isForceOverrideMode()) {
+    for (const { dependencies } of dependencyGroups) {
+      if (dependencies?.[VITE_PLUS_NAME]) {
+        dependencies[VITE_PLUS_NAME] = VITE_PLUS_VERSION;
+        needVitePlus = true;
+      }
+    }
+  }
   // remove packages that are replaced with vite-plus
   for (const name of REMOVE_PACKAGES) {
     let wasRemoved = false;
@@ -1889,7 +1906,7 @@ export function rewritePackageJson(
     // Add vitest to devDependencies when a remaining dependency likely
     // peer-depends on vitest (e.g., vitest-browser-svelte). Vite-plus already
     // bundles upstream vitest 4.1.5 as a direct dep, so the runtime resolution
-    // works without this — but strict pnpm / yarn-PnP refuse to expose a
+    // works without this — but strict pnpm / yarn Plug'n'Play refuse to expose a
     // transitive `vitest` to satisfy a peer dep declared by a different
     // direct dep. Adding `vitest` to the user's devDependencies pins the
     // peer-dep target to the same upstream version vite-plus ships with.