refactor(cli): remove unused exported helpers (#2046)

### Problem

Six exported helpers in `packages/cli/src/utils` are dead — each a thin
singular/prefix wrapper delegating to a plural/kept counterpart:

| file | symbol | status |
| --- | --- | --- |
| `utils/editor.ts` | `detectExistingEditor` | zero references (plural
`detectExistingEditors` is used) |
| `utils/agent.ts` | `resolveAgentTargetPath` | zero references (plural
`resolveAgentTargetPaths`) |
| `utils/agent.ts` | `selectAgentTargetPath` | zero references (plural
`selectAgentTargetPaths`) |
| `utils/agent.ts` | `detectExistingAgentTargetPath` | **test-only** —
referenced only by its own spec |
| `utils/terminal.ts` | `infoMsg` | zero references (only
`warnMsg`/`errorMsg` are used) |
| `utils/terminal.ts` | `noteMsg` | zero references |

**Why they are safe to delete (not just unreferenced):** `src/utils` is
not a public API surface — `package.json#exports` has no `./utils/*`
entry, and the public `.` entry (`index.ts`) only does `export * from
'@voidzero-dev/vite-plus-core'`. So these are internal-only.

### Fix

- Delete the six functions.
- `detectExistingAgentTargetPath` was exercised only by its own
`describe` block; its two singular assertions are migrated to the plural
`detectExistingAgentTargetPaths` (identical behaviour — the singular was
just `detectExistingAgentTargetPaths(...)?.[0]`): a one-file case now
asserts `['CLAUDE.md']`, and the symlink case still asserts `undefined`
(the plural returns `undefined` when nothing non-symlink is found).
- `rfcs/init-editor-configs.md` mentioned `selectAgentTargetPath` /
`detectExistingAgentTargetPath` in its design-analogy table; that table
now references the surviving plural functions (`selectAgentTargetPaths`
/ `detectExistingAgentTargetPaths`, mirrored by `selectEditors` /
`detectExistingEditors`) so the doc stays accurate.
- `terminal.ts`'s `info`/`note` half of the "info/note/warn/error" set
is gone, so the section comment is trimmed to the remaining
`warn`/`error`.

### Verification

```bash
# no code references remain to any removed symbol (excluding the plural forms we keep)
for s in detectExistingEditor resolveAgentTargetPath selectAgentTargetPath \
         detectExistingAgentTargetPath infoMsg noteMsg; do
  grep -rn "${s}\b" packages | grep -vE 'node_modules|/dist/' | grep -vE "${s}s\b"
done   # → no output

pnpm exec oxlint packages/cli/src/utils/{editor,agent,terminal}.ts \
                 packages/cli/src/utils/__tests__/agent.spec.ts   # clean
```

The migrated `detectExistingAgentTargetPaths` assertions match the
function's actual returns (`['CLAUDE.md']` for one file; `undefined` for
a symlink-only dir). Kept functions (`detectExistingEditors`,
`resolveAgentTargetPaths`, `selectAgentTargetPaths`,
`detectExistingAgentTargetPaths`, `warnMsg`, `errorMsg`) are untouched.

Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>

Author: shulaoda

packages/cli/src/utils/__tests__/agent.spec.ts

@@ -8,7 +8,6 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import {
   COPILOT_SETUP_WORKFLOW_PATH,
   detectExistingAgentTargetPaths,
-  detectExistingAgentTargetPath,
   hasExistingAgentInstructions,
   replaceMarkedAgentInstructionsSection,
   resolveAgentOptions,
@@ -376,7 +375,7 @@ describe('selectAgentTargetPaths', () => {
   });
 });
 
-describe('detectExistingAgentTargetPath', () => {
+describe('detectExistingAgentTargetPaths', () => {
   it('detects all existing regular agent files', async () => {
     const dir = await createProjectDir();
     await mockFs.writeFile(path.join(dir, 'AGENTS.md'), '# Agents');
@@ -389,14 +388,14 @@ describe('detectExistingAgentTargetPath', () => {
     const dir = await createProjectDir();
     await mockFs.writeFile(path.join(dir, 'CLAUDE.md'), '# Claude');
 
-    expect(detectExistingAgentTargetPath(dir)).toBe('CLAUDE.md');
+    expect(detectExistingAgentTargetPaths(dir)).toEqual(['CLAUDE.md']);
   });
 
   it('ignores symlinked agent files', async () => {
     const dir = await createProjectDir();
     await mockFs.symlink('AGENTS.md', path.join(dir, 'CLAUDE.md'));
 
-    expect(detectExistingAgentTargetPath(dir)).toBeUndefined();
+    expect(detectExistingAgentTargetPaths(dir)).toBeUndefined();
   });
 });
 

packages/cli/src/utils/agent.ts

@@ -174,19 +174,6 @@ export async function selectAgentTargetPaths({
   return selection.targetPaths;
 }
 
-export async function selectAgentTargetPath({
-  interactive,
-  agent,
-  onCancel,
-}: {
-  interactive: boolean;
-  agent?: AgentSelection;
-  onCancel: () => void;
-}) {
-  const targetPaths = await selectAgentTargetPaths({ interactive, agent, onCancel });
-  return targetPaths?.[0];
-}
-
 export function detectExistingAgentTargetPaths(projectRoot: string) {
   const detectedPaths: string[] = [];
   const seenTargetPaths = new Set<string>();
@@ -203,10 +190,6 @@ export function detectExistingAgentTargetPaths(projectRoot: string) {
   return detectedPaths.length > 0 ? detectedPaths : undefined;
 }
 
-export function detectExistingAgentTargetPath(projectRoot: string) {
-  return detectExistingAgentTargetPaths(projectRoot)?.[0];
-}
-
 export function hasExistingAgentInstructions(projectRoot: string): boolean {
   const targetPaths = detectExistingAgentTargetPaths(projectRoot);
   if (!targetPaths) {
@@ -259,10 +242,6 @@ export function resolveAgentTargetPaths(agent?: string | string[]) {
   return getAgentTargetPaths(resolveAgentOptions(agent));
 }
 
-export function resolveAgentTargetPath(agent?: string) {
-  return resolveAgentTargetPaths(agent)[0] ?? 'AGENTS.md';
-}
-
 export function resolveAgentOptions(agent?: string | string[]) {
   const agentNames = parseAgentNames(agent);
   const resolvedAgentNames = agentNames.length > 0 ? agentNames : [AGENT_DEFAULT_ID];

packages/cli/src/utils/editor.ts

@@ -273,10 +273,6 @@ export async function selectEditors({
   return undefined;
 }
 
-export function detectExistingEditor(projectRoot: string): EditorId | undefined {
-  return detectExistingEditors(projectRoot)?.[0];
-}
-
 export function detectExistingEditors(projectRoot: string): EditorId[] | undefined {
   const editors: EditorId[] = [];
   for (const option of EDITORS) {

packages/cli/src/utils/terminal.ts

@@ -37,12 +37,7 @@ export function error(text: string) {
 }
 
 // Standard message prefix functions matching the Rust CLI convention.
-// info/note go to stdout (normal output), warn/error go to stderr (diagnostics).
-
-export function infoMsg(msg: string) {
-  /* oxlint-disable-next-line no-console */
-  console.log(styleText(['blue', 'bold'], 'info:'), msg);
-}
+// warn/error go to stderr (diagnostics).
 
 export function warnMsg(msg: string) {
   /* oxlint-disable-next-line no-console */
@@ -53,8 +48,3 @@ export function errorMsg(msg: string) {
   /* oxlint-disable-next-line no-console */
   console.error(styleText(['red', 'bold'], 'error:'), msg);
 }
-
-export function noteMsg(msg: string) {
-  /* oxlint-disable-next-line no-console */
-  console.log(styleText(['gray', 'bold'], 'note:'), msg);
-}

rfcs/init-editor-configs.md

@@ -81,12 +81,12 @@ When a config file already exists:
 
 Mirrors `packages/cli/src/utils/agent.ts` structure:
 
-| agent.ts                          | editor.ts                |
-| --------------------------------- | ------------------------ |
-| `AGENTS` array                    | `EDITORS` array          |
-| `selectAgentTargetPath()`         | `selectEditor()`         |
-| `detectExistingAgentTargetPath()` | `detectExistingEditor()` |
-| `writeAgentInstructions()`        | `writeEditorConfigs()`   |
+| agent.ts                           | editor.ts                 |
+| ---------------------------------- | ------------------------- |
+| `AGENTS` array                     | `EDITORS` array           |
+| `selectAgentTargetPaths()`         | `selectEditors()`         |
+| `detectExistingAgentTargetPaths()` | `detectExistingEditors()` |
+| `writeAgentInstructions()`         | `writeEditorConfigs()`    |
 
 Key difference from agent.ts: Uses JSON merge (via `utils/json.ts`) instead of file copy/append, since IDE configs are structured JSON.