refactor(create): fold findWorkspaceRoot to a single pass + small cleanups

Post-simplify cleanup:

- `findWorkspaceRoot` now uses a single walk with a deferred `.git`
  match. The two-pass version walked the entire ancestry twice in the
  no-marker case; now we record the first `.git` seen and return it
  only after the walk exhausts without finding a monorepo marker.
  Same "markers win globally" semantics, half the I/O.
- Export `hasViteConfig` and use it in `getConfiguredDefaultTemplate`
  instead of the degenerate `findViteConfigUp(x, x)` (start == stop
  meant it only checked the single directory anyway).
- Drop the dead `?? 'template'` fallback in `bin.ts` —
  `bundledEntryName` is always set whenever `isBundledTemplate` is true
  (both come from the same `resolved.kind === 'bundled'` branch).
- `fetchNpmResource` init type is now `Omit<RequestInit, 'signal'>`
  so callers can't accidentally pass a `signal` that the
  `AbortSignal.timeout(timeoutMs)` inside would silently override.
- Tighten `expandNpmrcValue` JSDoc to list the four `.npmrc` features
  we do NOT handle (backslash escapes, `${VAR-default}`, inline `;`
  comments, `key[]=` lists).

Author: fengmk2

packages/cli/src/create/bin.ts

@@ -633,7 +633,7 @@ Use \`vp create --list\` to list all available templates, or run \`vp create --h
   }
 
   const directScaffoldFallbackName = isBundledTemplate
-    ? `vite-plus-${bundledEntryName ?? 'template'}`
+    ? `vite-plus-${bundledEntryName}`
     : selectedTemplateName === BuiltinTemplate.monorepo
       ? 'vite-plus-monorepo'
       : `vite-plus-${selectedTemplateName.split(':')[1]}`;

packages/cli/src/create/org-resolve.ts

@@ -1,6 +1,6 @@
 import * as prompts from '@voidzero-dev/vite-plus-prompts';
 
-import { findViteConfigUp, findWorkspaceRoot, resolveViteConfig } from '../resolve-vite-config.ts';
+import { findWorkspaceRoot, hasViteConfig, resolveViteConfig } from '../resolve-vite-config.ts';
 import {
   filterManifestForContext,
   isRelativePath,
@@ -202,7 +202,7 @@ export async function resolveOrgManifestForCreate(args: {
  */
 export async function getConfiguredDefaultTemplate(startDir: string): Promise<string | undefined> {
   const projectRoot = findWorkspaceRoot(startDir) ?? startDir;
-  if (!findViteConfigUp(projectRoot, projectRoot)) {
+  if (!hasViteConfig(projectRoot)) {
     return undefined;
   }
   try {

packages/cli/src/resolve-vite-config.ts

@@ -34,26 +34,23 @@ export function findViteConfigUp(startDir: string, stopDir: string): string | un
   return undefined;
 }
 
-function hasViteConfig(dir: string): boolean {
+export function hasViteConfig(dir: string): boolean {
   return VITE_CONFIG_FILES.some((f) => fs.existsSync(path.join(dir, f)));
 }
 
 /**
  * Find the workspace / repo root by walking up from `startDir`.
  *
- * Primary pass: stop at the first `pnpm-workspace.yaml`, `workspaces`
- * in `package.json`, or `lerna.json` — the authoritative monorepo
- * markers.
- *
- * Fallback pass: if no marker is found anywhere in the ancestry, walk
- * again looking for `.git` so standalone git repos still resolve to
- * their repo boundary. `.git` is deliberately NOT checked in the first
- * pass — a subproject with its own `.git` (git submodule, nested clone)
- * must not preempt a monorepo marker higher up the tree.
+ * Monorepo markers (`pnpm-workspace.yaml`, `workspaces` in `package.json`,
+ * `lerna.json`) win globally — they always take precedence over any
+ * `.git` seen along the way, so a subproject with its own `.git` (git
+ * submodule, nested clone) can't preempt a marker higher up the tree.
+ * `.git` is only returned when the walk finishes without finding any
+ * monorepo marker.
  */
 export function findWorkspaceRoot(startDir: string): string | undefined {
-  const startResolved = path.resolve(startDir);
-  let dir = startResolved;
+  let dir = path.resolve(startDir);
+  let gitFallback: string | undefined;
   while (true) {
     if (fs.existsSync(path.join(dir, 'pnpm-workspace.yaml'))) {
       return dir;
@@ -72,26 +69,16 @@ export function findWorkspaceRoot(startDir: string): string | undefined {
     if (fs.existsSync(path.join(dir, 'lerna.json'))) {
       return dir;
     }
-    const parent = path.dirname(dir);
-    if (parent === dir) {
-      break;
-    }
-    dir = parent;
-  }
-  // Fallback: no monorepo marker found in the ancestry. Walk again
-  // looking for a `.git` directory as the standalone repo boundary.
-  dir = startResolved;
-  while (true) {
-    if (fs.existsSync(path.join(dir, '.git'))) {
-      return dir;
+    if (gitFallback === undefined && fs.existsSync(path.join(dir, '.git'))) {
+      gitFallback = dir;
     }
     const parent = path.dirname(dir);
     if (parent === dir) {
       break;
     }
     dir = parent;
   }
-  return undefined;
+  return gitFallback;
 }
 
 export interface ResolveViteConfigOptions {

packages/cli/src/utils/npm-config.ts

@@ -5,11 +5,12 @@ import path from 'node:path';
 type NpmConfig = Map<string, string>;
 
 function expandNpmrcValue(raw: string): string {
-  // Strip surrounding quotes and expand `${VAR}` references.
-  // Narrow subset of npm's `.npmrc` behavior — covers only the keys we
-  // actually read (registry / @scope:registry / :_authToken / :_auth /
-  // :username / :_password). Escape sequences and nested expansion are
-  // intentionally ignored.
+  // Strip surrounding quotes and expand `${VAR}` references. Covers only
+  // the value shapes used by the keys we actually read (registry /
+  // @scope:registry / :_authToken / :_auth / :username / :_password).
+  // Intentionally NOT handled: `\$` backslash escapes, `${VAR-default}`
+  // fallbacks, inline `;` comments after a value, and `key[]=` list
+  // syntax. Extend when a caller needs any of those.
   let value = raw.trim();
   if (
     (value.startsWith('"') && value.endsWith('"')) ||
@@ -167,7 +168,7 @@ export function getNpmAuthHeader(registryOrUrl: string): string | undefined {
  */
 export async function fetchNpmResource(
   url: string,
-  init: RequestInit & { timeoutMs: number },
+  init: Omit<RequestInit, 'signal'> & { timeoutMs: number },
 ): Promise<Response> {
   const { timeoutMs, headers: callerHeaders, ...rest } = init;
   const first = await fetch(url, {