Skip to content

Commit c3108b3

Browse files
committed
fix(cli): use runner configLoader to suppress Rolldown warnings in migration
1 parent ce97828 commit c3108b3

9 files changed

Lines changed: 239 additions & 227 deletions

File tree

packages/cli/snap-tests-global/migration-merge-vite-config-ts/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
},
1818
"devDependencies": {
1919
"@vitejs/plugin-react": "^4.2.0",
20+
"@vitest/browser-playwright": "^4.0.0",
2021
"oxfmt": "1",
2122
"oxlint": "1",
2223
"vite": "^7.0.0",

packages/cli/snap-tests-global/migration-monorepo-pnpm-overrides-dependency-selector/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"dev": "vite"
66
},
77
"devDependencies": {
8+
"@vitejs/plugin-react": "catalog:",
89
"vite": "catalog:"
910
},
1011
"packageManager": "pnpm@10.20.0+sha512.cf9998222162dd85864d0a8102e7892e7ba4ceadebbf5a31f9c2fce48dfce317a9c53b9f6464d1ef9042cba2e02ae02a9f7c143a2b438cd93c91840f0192b9dd",

packages/cli/snap-tests-global/migration-monorepo-pnpm-overrides-dependency-selector/snap.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export default defineConfig({
2626
"prepare": "vp config"
2727
},
2828
"devDependencies": {
29+
"@vitejs/plugin-react": "catalog:",
2930
"vite": "catalog:",
3031
"vite-plus": "catalog:"
3132
},

packages/cli/snap-tests-global/migration-monorepo-pnpm/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"testnpm2": "1.0.0"
1717
},
1818
"devDependencies": {
19+
"@vitejs/plugin-react": "catalog:",
1920
"oxfmt": "catalog:",
2021
"oxlint": "catalog:",
2122
"vite": "catalog:",

packages/cli/snap-tests-global/migration-monorepo-pnpm/snap.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ cat: .oxfmtrc.json: No such file or directory
6262
"testnpm2": "1.0.0"
6363
},
6464
"devDependencies": {
65+
"@vitejs/plugin-react": "catalog:",
6566
"vite": "catalog:",
6667
"vitest": "catalog:",
6768
"vite-plus": "catalog:"

packages/cli/snap-tests-global/migration-monorepo-yarn4/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"testnpm2": "1.0.0"
2020
},
2121
"devDependencies": {
22+
"@vitejs/plugin-react": "catalog:",
2223
"oxfmt": "catalog:",
2324
"oxlint": "catalog:",
2425
"vite": "catalog:",

packages/cli/snap-tests-global/migration-monorepo-yarn4/snap.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ cat: .oxlintrc.json: No such file or directory
5353
"testnpm2": "1.0.0"
5454
},
5555
"devDependencies": {
56+
"@vitejs/plugin-react": "catalog:",
5657
"vite": "catalog:",
5758
"vitest": "catalog:",
5859
"vite-plus": "catalog:"

packages/cli/src/migration/bin.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,12 @@ async function checkRolldownCompatibility(rootDir: string, report: MigrationRepo
543543
try {
544544
const { resolveConfig } = await import('../index.js');
545545
const { checkManualChunksCompat } = await import('./compat.js');
546-
const config = await resolveConfig({ root: rootDir, logLevel: 'silent' }, 'build');
546+
// Use 'runner' configLoader to avoid Rolldown bundling the config file,
547+
// which prints UNRESOLVED_IMPORT warnings that cannot be suppressed via logLevel.
548+
const config = await resolveConfig(
549+
{ root: rootDir, logLevel: 'silent', configLoader: 'runner' },
550+
'build',
551+
);
547552
checkManualChunksCompat(config.build?.rollupOptions?.output, report);
548553
} catch {
549554
// Config resolution may fail — skip compatibility check silently

0 commit comments

Comments
 (0)