Skip to content

Commit d025673

Browse files
authored
fix: update build-types filter from rolldown-vite to vite (#342)
### TL;DR Updated build scripts to use the correct package filter for building types and added a postbuild script to verify output files. ### What changed? - Changed the package filter in GitHub action from `rolldown-vite` to `vite` for the `build-types` command in three different build configurations - Added a `postbuild` script to the core package that runs after build completion to list files in the `dist/vite/node` directory ### How to test? 1. Run the build process using the GitHub action to verify that types are correctly built using the `vite` filter 2. Check the build logs to confirm that the `postbuild` script executes and displays the contents of the `dist/vite/node` directory ### Why make this change? The package filter was incorrectly referencing `rolldown-vite` instead of `vite`, which could cause type generation to fail or target the wrong package. The added postbuild script helps with debugging by providing visibility into the build output files, making it easier to verify that the correct files are being generated.
1 parent 8c33047 commit d025673

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/actions/build-upstream/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ runs:
2020
pnpm --filter rolldown build-binding:release --target ${{ inputs.target }} --use-napi-cross
2121
fi
2222
pnpm --filter rolldown build-node
23-
pnpm --filter rolldown-vite build-types
23+
pnpm --filter vite build-types
2424
pnpm --filter=@voidzero-dev/vite-plus-core build
2525
pnpm --filter=@voidzero-dev/vite-plus-test build
2626
CC=clang pnpm --filter=@voidzero-dev/vite-plus build --target ${{ inputs.target }} --use-napi-cross
@@ -36,7 +36,7 @@ runs:
3636
pnpm --filter rolldown build-binding:release --target ${{ inputs.target }} --use-napi-cross
3737
fi
3838
pnpm --filter rolldown build-node
39-
pnpm --filter rolldown-vite build-types
39+
pnpm --filter vite build-types
4040
pnpm --filter=@voidzero-dev/vite-plus-core build
4141
pnpm --filter=@voidzero-dev/vite-plus-test build
4242
TARGET_CFLAGS="-D_BSD_SOURCE" pnpm --filter=@voidzero-dev/vite-plus build --target ${{ inputs.target }} --use-napi-cross
@@ -52,7 +52,7 @@ runs:
5252
pnpm --filter rolldown build-binding:release --target ${{ inputs.target }}
5353
fi
5454
pnpm --filter rolldown build-node
55-
pnpm --filter rolldown-vite build-types
55+
pnpm --filter vite build-types
5656
pnpm --filter=@voidzero-dev/vite-plus-core build
5757
pnpm --filter=@voidzero-dev/vite-plus-test build
5858
pnpm --filter=@voidzero-dev/vite-plus build --target ${{ inputs.target }}

0 commit comments

Comments
 (0)