test: apply cleanup review to the local registry change

- extract the shared pack preflight+invocation into
  packages/tools/src/pack-local-vite-plus.ts, used by both the snap harness
  and local-npm-registry.ts --pack (was two hand-synced copies)
- localVitePlusPackages fixtures get a 120s default command timeout in the
  harness instead of a pasted "timeout": 120000 on every wrapped command;
  steps.json env is optional now and empty env blocks are gone
- drop the dead SNAP_CASES_DIR env (its last consumer left with .shared/)
- serve packuments without a parse/stringify round trip and read local
  tarballs asynchronously so large responses do not stall in-flight proxied
  requests
- tool local-npm-registry spawns the script by path instead of importing it
  under a spliced argv, so tool-launched servers match --ps/--kill
- key the ecosystem release-age gate exception on resolutionMode: time-based
  in the project's workspace yaml instead of the dify project name
- derive the expected e2e version from the packed tgz (vitePlusTgzVersion in
  ecosystem-ci/paths.ts) for both patch-project and verify-install, dropping
  the unused VP_EXPECTED_VERSION knob and the hardcoded 0.0.0
- document why the registry's upstream resolution deliberately ignores
  registry env vars

Author: fengmk2

.github/workflows/e2e-test.yml

@@ -111,14 +111,13 @@ jobs:
           mkdir -p tmp/tgz
           # patch-project.ts serves these tgz through a local npm registry
           # (packages/tools/src/local-npm-registry.ts), so `vp migrate` pins
-          # and installs them like a real release. Pin both packages to 0.0.0
-          # so a correctly installed local build is always distinguishable
-          # from any published version (verify-install.ts asserts it), even on
-          # a release commit that leaves packages/{core,cli} at a published
-          # version. The bun-only vite alias tgz that the old file:-override
-          # flow needed (bun peer-dep strictness, oven-sh/bun#8406) is gone:
-          # through the registry, bun installs the standard
-          # `vite -> npm:@voidzero-dev/vite-plus-core@<version>` alias.
+          # and installs them like a real release, with every package manager
+          # (including bun) resolving the standard
+          # `vite -> npm:@voidzero-dev/vite-plus-core@<version>` alias. Pin
+          # both packages to 0.0.0 so a correctly installed local build is
+          # always distinguishable from any published version
+          # (verify-install.ts asserts it), even on a release commit that
+          # leaves packages/{core,cli} at a published version.
           (cd packages/core && npm pkg set version=0.0.0)
           (cd packages/cli && npm pkg set version=0.0.0)
           cd packages/core && pnpm pack --pack-destination ../../tmp/tgz && cd ../..

ecosystem-ci/patch-project.ts

@@ -1,10 +1,10 @@
 import { execSync, spawn } from 'node:child_process';
-import { readdirSync } from 'node:fs';
+import { existsSync, readFileSync } from 'node:fs';
 import { appendFile, readFile, writeFile } from 'node:fs/promises';
 import { join } from 'node:path';
 
 import { VITEST_VERSION } from '../packages/cli/src/utils/constants.ts';
-import { ecosystemCiDir, tgzDir } from './paths.ts';
+import { ecosystemCiDir, tgzDir, vitePlusTgzVersion } from './paths.ts';
 import repos from './repo.json' with { type: 'json' };
 
 const projects = Object.keys(repos);
@@ -26,15 +26,7 @@ const cli = process.env.VP_CLI_BIN ?? 'vp';
 // The packed local build in tmp/tgz is served through a local npm registry
 // (local-npm-registry.ts), so vp migrate pins and installs the checkout's
 // own version through the standard registry code paths, with no `file:` specs.
-// The e2e build job pins packages/cli to 0.0.0 before `pnpm pack`; a local
-// run can serve whatever version the checkout carries.
-const vitePlusVersion = readdirSync(tgzDir)
-  .map((entry) => /^vite-plus-(\d.*)\.tgz$/.exec(entry)?.[1])
-  .find(Boolean);
-if (!vitePlusVersion) {
-  console.error(`No vite-plus-<version>.tgz found in ${tgzDir}`);
-  process.exit(1);
-}
+const vitePlusVersion = vitePlusTgzVersion();
 
 const registryScript = join(
   import.meta.dirname,
@@ -166,20 +158,23 @@ const vitestOverrides = {
 // publish does not fail with ERR_PNPM_NO_MATURE_MATCHING_VERSION. pnpm >= 10.6
 // only reads the PNPM_CONFIG_* spelling; older pnpm reads the lowercase form.
 //
-// dify is the exception: it sets `resolutionMode: time-based`, and defining a
-// minimumReleaseAge (even 0, via any env spelling) activates pnpm's
-// resolution-policy engine, which vp's bundled pnpm cannot handle
-// (ERR_PNPM_RESOLUTION_POLICY_VIOLATIONS_UNHANDLED, no
-// handleResolutionPolicyViolations callback). Its `minimumReleaseAge:` key
-// was already removed above, so with no gate env the policy stays inactive
-// and installs work.
-const releaseAgeEnv =
-  project === 'dify'
-    ? {}
-    : {
-        pnpm_config_minimum_release_age: '0',
-        PNPM_CONFIG_MINIMUM_RELEASE_AGE: '0',
-      };
+// Projects with `resolutionMode: time-based` (currently dify) are the
+// exception: defining a minimumReleaseAge (even 0, via any env spelling)
+// activates pnpm's resolution-policy engine there, which vp's bundled pnpm
+// cannot handle (ERR_PNPM_RESOLUTION_POLICY_VIOLATIONS_UNHANDLED, no
+// handleResolutionPolicyViolations callback wired). Their `minimumReleaseAge:`
+// key is stripped by the per-project patches above, so with no gate env the
+// policy stays inactive and installs work.
+const workspaceYamlPath = join(repoRoot, 'pnpm-workspace.yaml');
+const timeBasedResolution =
+  existsSync(workspaceYamlPath) &&
+  /^resolutionMode:\s*time-based/m.test(readFileSync(workspaceYamlPath, 'utf-8'));
+const releaseAgeEnv = timeBasedResolution
+  ? {}
+  : {
+      pnpm_config_minimum_release_age: '0',
+      PNPM_CONFIG_MINIMUM_RELEASE_AGE: '0',
+    };
 
 const migrateEnv: NodeJS.ProcessEnv = {
   ...process.env,

ecosystem-ci/paths.ts

@@ -1,3 +1,4 @@
+import { readdirSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
@@ -11,3 +12,19 @@ export const ecosystemCiDir = join(tempBase, 'vite-plus-ecosystem-ci');
 
 // tgz path: always use local tmp/tgz
 export const tgzDir = join(projectDir, '..', 'tmp', 'tgz');
+
+/**
+ * The version of the packed vite-plus tgz that the local registry serves and
+ * that `vp migrate` pins: 0.0.0 on CI (the e2e pack step pins it so a local
+ * build is always distinguishable from a published version), the checkout
+ * version on a local run.
+ */
+export function vitePlusTgzVersion(): string {
+  const version = readdirSync(tgzDir)
+    .map((entry) => /^vite-plus-(\d.*)\.tgz$/.exec(entry)?.[1])
+    .find(Boolean);
+  if (!version) {
+    throw new Error(`No vite-plus-<version>.tgz found in ${tgzDir}`);
+  }
+  return version;
+}

ecosystem-ci/verify-install.ts

@@ -2,14 +2,15 @@ import { readFileSync } from 'node:fs';
 import { createRequire } from 'node:module';
 import path from 'node:path';
 
+import { vitePlusTgzVersion } from './paths.ts';
+
 const require = createRequire(`${process.cwd()}/`);
 
-// The ecosystem-ci pack step pins packages/cli to 0.0.0 before `pnpm pack`,
-// and patch-project.ts serves that build through the local registry, so a
-// correctly installed local build always reports 0.0.0, never a published
-// registry version. A local (non-CI) run serves whatever version the checkout
-// carries; pass it via VP_EXPECTED_VERSION.
-const expectedVersion = process.env.VP_EXPECTED_VERSION ?? '0.0.0';
+// patch-project.ts serves the packed tgz through the local registry, so a
+// correctly installed local build always reports the tgz version (0.0.0 on
+// CI, where the pack step pins it precisely so a local build is never
+// mistaken for a published registry version).
+const expectedVersion = vitePlusTgzVersion();
 
 try {
   const pkgPath = require.resolve('vite-plus/package.json');

packages/cli/snap-tests-global/create-framework-shim-astro/steps.json

@@ -1,18 +1,15 @@
 {
   "ignoredPlatforms": ["win32"],
   "localVitePlusPackages": true,
-  "env": {},
   "commands": [
     {
       "command": "node $SNAP_LOCAL_REGISTRY -- vp create astro --no-interactive -- my-astro-app --yes --skip-houston --template basics # create Astro app",
-      "ignoreOutput": true,
-      "timeout": 120000
+      "ignoreOutput": true
     },
     "cat my-astro-app/src/env.d.ts # check Astro shim",
     {
       "command": "cd my-astro-app && node $SNAP_LOCAL_REGISTRY -- vp install --ignore-scripts -- --no-frozen-lockfile # install dependencies",
-      "ignoreOutput": true,
-      "timeout": 120000
+      "ignoreOutput": true
     },
     {
       "command": "cd my-astro-app && sed -i.bak -e '/jsPlugins/d' -e '/rules:/d' -e '/options:/d' vite.config.ts && vp check --fix # fix generated formatting and ensure no errors"

packages/cli/snap-tests-global/create-framework-shim-vue/steps.json

@@ -1,19 +1,22 @@
 {
-  "ignoredPlatforms": ["win32", { "os": "linux", "libc": "musl" }],
+  "ignoredPlatforms": [
+    "win32",
+    {
+      "os": "linux",
+      "libc": "musl"
+    }
+  ],
   "linkCheckoutPackages": true,
   "localVitePlusPackages": true,
-  "env": {},
   "commands": [
     {
       "command": "node $SNAP_LOCAL_REGISTRY -- vp create vite:application --no-interactive -- --template vue-ts # create Vue+TS app",
-      "ignoreOutput": true,
-      "timeout": 120000
+      "ignoreOutput": true
     },
     "cat vite-plus-application/src/env.d.ts # check Vue shim was added",
     {
       "command": "cd vite-plus-application && node $SNAP_LOCAL_REGISTRY -- vp install # install dependencies",
-      "ignoreOutput": true,
-      "timeout": 120000
+      "ignoreOutput": true
     },
     "cd vite-plus-application && vp check --fix # fix generated formatting and ensure no errors"
   ]

packages/cli/snap-tests-global/migration-framework-shim-astro-vue/steps.json

@@ -7,10 +7,7 @@
     "VP_SKIP_INSTALL": ""
   },
   "commands": [
-    {
-      "command": "node $SNAP_LOCAL_REGISTRY -- vp migrate --no-interactive --no-hooks # migration should add both Vue and Astro shims",
-      "timeout": 120000
-    },
+    "node $SNAP_LOCAL_REGISTRY -- vp migrate --no-interactive --no-hooks # migration should add both Vue and Astro shims",
     "cat src/env.d.ts # check both shims were written"
   ]
 }

packages/cli/snap-tests-global/migration-framework-shim-astro/steps.json

@@ -7,10 +7,7 @@
     "VP_SKIP_INSTALL": ""
   },
   "commands": [
-    {
-      "command": "node $SNAP_LOCAL_REGISTRY -- vp migrate --no-interactive --no-hooks # migration should add Astro shim when astro dependency is detected",
-      "timeout": 120000
-    },
+    "node $SNAP_LOCAL_REGISTRY -- vp migrate --no-interactive --no-hooks # migration should add Astro shim when astro dependency is detected",
     "cat src/env.d.ts # check Astro shim was written"
   ]
 }

packages/cli/snap-tests-global/migration-framework-shim-vue/steps.json

@@ -7,10 +7,7 @@
     "VP_SKIP_INSTALL": ""
   },
   "commands": [
-    {
-      "command": "node $SNAP_LOCAL_REGISTRY -- vp migrate --no-interactive --no-hooks # migration should add Vue shim when vue dependency is detected",
-      "timeout": 120000
-    },
+    "node $SNAP_LOCAL_REGISTRY -- vp migrate --no-interactive --no-hooks # migration should add Vue shim when vue dependency is detected",
     "cat src/env.d.ts # check Vue shim was written"
   ]
 }

packages/cli/snap-tests-global/migration-standalone-npm/steps.json

@@ -7,10 +7,7 @@
     "VP_SKIP_INSTALL": ""
   },
   "commands": [
-    {
-      "command": "node $SNAP_LOCAL_REGISTRY -- vp migrate --no-interactive --no-hooks # migration should work with npm, add overrides, and update lockfile",
-      "timeout": 120000
-    },
+    "node $SNAP_LOCAL_REGISTRY -- vp migrate --no-interactive --no-hooks # migration should work with npm, add overrides, and update lockfile",
     "cat package.json # check package.json has overrides field (not pnpm.overrides)",
     "node -e \"const lock = require('./package-lock.json'); const vite = lock.packages['node_modules/vite']; if (vite && (vite.name === '@voidzero-dev/vite-plus-core' || vite.resolved?.includes('/@voidzero-dev/vite-plus-core/'))) console.log('lockfile has vite override'); else { console.error('vite override not found in lockfile'); process.exit(1); }\" # verify lockfile updated with override"
   ]