Skip to content

Commit d248980

Browse files
authored
test(cli): stabilize global snap tests against pnpm v11 (#1528)
Five fixtures that ran `vp install` or `vp migrate` had no `packageManager` set, so vite_install fell through to its `latest` default (now pnpm v11). pnpm v11 fails the install with `ERR_PNPM_IGNORED_BUILDS` for transitive esbuild/sharp build scripts where v10 only warned. Pin each fixture to `pnpm@10.33.2` to match the repo's own packageManager. Separately, `create-framework-shim-astro`'s install step also tripped the strict-CI builds check on a clean runner; pass `--ignore-scripts` so pnpm doesn't try to run them at all.
1 parent 1227bce commit d248980

10 files changed

Lines changed: 16 additions & 10 deletions

File tree

packages/cli/snap-tests-global/create-framework-shim-astro/snap.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
> cat my-astro-app/src/env.d.ts # check Astro shim
33
/// <reference types="astro/client" />
44

5-
> cd my-astro-app && vp install -- --no-frozen-lockfile # install dependencies
5+
> cd my-astro-app && vp install --ignore-scripts -- --no-frozen-lockfile # install dependencies
66
> cd my-astro-app && vp check --fix # fix generated formatting and ensure no errors
77
pass: Formatting completed for checked files (<variable>ms)
88
pass: Found no warnings, lint errors, or type errors in 6 files (<variable>ms, <variable> threads)

packages/cli/snap-tests-global/create-framework-shim-astro/steps.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
},
88
"cat my-astro-app/src/env.d.ts # check Astro shim",
99
{
10-
"command": "cd my-astro-app && vp install -- --no-frozen-lockfile # install dependencies",
10+
"command": "cd my-astro-app && vp install --ignore-scripts -- --no-frozen-lockfile # install dependencies",
1111
"ignoreOutput": true
1212
},
1313
"cd my-astro-app && vp check --fix # fix generated formatting and ensure no errors"

packages/cli/snap-tests-global/migration-framework-shim-astro-vue/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@
44
"astro": "^4.0.0",
55
"vite": "^7.0.0",
66
"vue": "^3.0.0"
7-
}
7+
},
8+
"packageManager": "pnpm@10.33.2"
89
}

packages/cli/snap-tests-global/migration-framework-shim-astro/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@
33
"devDependencies": {
44
"astro": "^4.0.0",
55
"vite": "^7.0.0"
6-
}
6+
},
7+
"packageManager": "pnpm@10.33.2"
78
}

packages/cli/snap-tests-global/migration-framework-shim-vue/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@
33
"devDependencies": {
44
"vite": "^7.0.0",
55
"vue": "^3.0.0"
6-
}
6+
},
7+
"packageManager": "pnpm@10.33.2"
78
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"devDependencies": {
33
"vite": "^6.0.0"
4-
}
4+
},
5+
"packageManager": "pnpm@10.33.2"
56
}

packages/cli/snap-tests-global/migration-not-supported-vite6/snap.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ Vite+ cannot automatically migrate this project yet.
1313
"vite": "^6.0.0"
1414
},
1515
"packageManager": "pnpm@<semver>"
16-
}
16+
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"devDependencies": {
33
"vitest": "^3.0.0"
4-
}
4+
},
5+
"packageManager": "pnpm@10.33.2"
56
}

packages/cli/snap-tests-global/migration-not-supported-vitest3/snap.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ Vite+ cannot automatically migrate this project yet.
1313
"vitest": "^3.0.0"
1414
},
1515
"packageManager": "pnpm@<semver>"
16-
}
16+
}

packages/cli/snap-tests-global/migration-standalone-pnpm/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@
33
"devDependencies": {
44
"vite": "^7.0.0",
55
"vitest": "^4.0.0"
6-
}
6+
},
7+
"packageManager": "pnpm@10.33.2"
78
}

0 commit comments

Comments
 (0)