Skip to content

Commit d834f63

Browse files
committed
feat(nushell): improve Fish completion delegation for Nushell integration
1 parent e4d445d commit d834f63

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

  • crates/vite_global_cli/src/commands/env

crates/vite_global_cli/src/commands/env/setup.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ pub async fn execute(refresh: bool, env_only: bool) -> Result<ExitStatus, Error>
4646
// Create env files with PATH guard (prevents duplicate PATH entries)
4747
create_env_files(&vite_plus_home).await?;
4848

49-
// Generate Fish completion file at ~/.vite-plus/vp.fish for use by the Nushell completer.
50-
// Fish completions are generated statically so that Nushell can delegate to Fish at runtime.
49+
// Generate Fish completion file at ~/.vite-plus/vp.fish for Fish shell users.
50+
// Nushell completions delegate to Fish dynamically via VP_COMPLETE=fish at runtime.
5151
// command_with_help() uses a deep call stack, so we spawn a thread with a larger stack.
5252
let fish_completions_path = vite_plus_home.join("vp.fish").as_path().to_path_buf();
5353
std::thread::Builder::new()
@@ -518,8 +518,8 @@ complete -c vpr --keep-order --exclusive --arguments "(__vpr_complete)"
518518
tokio::fs::write(&env_fish_file, env_fish_content).await?;
519519

520520
// Nushell env file with vp wrapper function.
521-
// Completions delegate to Fish via vp.fish because clap_complete_nushell generates
522-
// multiple rest params (e.g. for `vp install`), which Nushell does not support.
521+
// Completions delegate to Fish dynamically (VP_COMPLETE=fish) because clap_complete_nushell
522+
// generates multiple rest params (e.g. for `vp install`), which Nushell does not support.
523523
let env_nu_content = r#"# Vite+ environment setup (https://viteplus.dev)
524524
$env.PATH = ($env.PATH | where { $in != "__VP_BIN__" } | prepend "__VP_BIN__")
525525
@@ -771,8 +771,8 @@ mod tests {
771771
"env.nu should set VP_ENV_USE_EVAL_ENABLE"
772772
);
773773
assert!(
774-
nu_content.contains("vp.fish"),
775-
"env.nu should reference the Fish completion file for Nushell delegation"
774+
nu_content.contains("VP_COMPLETE=fish"),
775+
"env.nu should use dynamic Fish completion delegation"
776776
);
777777
assert!(
778778
nu_content.contains("VP_SHELL_NU"),

0 commit comments

Comments
 (0)