Skip to content

Commit e36e950

Browse files
committed
simplify: remove Dev Drive, keep Defender-disable only
Dev Drive caused cache invalidation issues and didn't improve times when the cargo target cache was warm. The simpler Defender-disable approach (Set-MpPreference) was already effective at ~6min. Changes: - ci.yml: Remove setup-dev-drive from Test and CLI E2E Windows jobs - ci.yml: Keep Defender disable (already proven) - e2e-test.yml: Keep new Defender disable additions (unchanged)
1 parent b8fa6cf commit e36e950

File tree

1 file changed

+0
-23
lines changed

1 file changed

+0
-23
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -76,18 +76,6 @@ jobs:
7676
shell: powershell
7777
run: Set-MpPreference -DisableRealtimeMonitoring $true
7878

79-
# Use Dev Drive with ReFS for CARGO_HOME/RUSTUP_HOME on Windows
80-
# Only cargo/rustup dirs go on the Dev Drive (no workspace-copy) to preserve target dir cache
81-
- name: Setup Dev Drive
82-
uses: samypr100/setup-dev-drive@30f0f98ae5636b2b6501e181dfb3631b9974818d # v4.0.0
83-
if: runner.os == 'Windows'
84-
with:
85-
drive-size: 8GB
86-
drive-format: ReFS
87-
env-mapping: |
88-
CARGO_HOME,{{ DEV_DRIVE }}/.cargo
89-
RUSTUP_HOME,{{ DEV_DRIVE }}/.rustup
90-
9179
- uses: oxc-project/setup-rust@d286d43bc1f606abbd98096666ff8be68c8d5f57 # v1.0.0
9280
with:
9381
save-cache: ${{ github.ref_name == 'main' }}
@@ -210,17 +198,6 @@ jobs:
210198
shell: powershell
211199
run: Set-MpPreference -DisableRealtimeMonitoring $true
212200

213-
# Use Dev Drive with ReFS for CARGO_HOME/RUSTUP_HOME on Windows
214-
- name: Setup Dev Drive
215-
uses: samypr100/setup-dev-drive@30f0f98ae5636b2b6501e181dfb3631b9974818d # v4.0.0
216-
if: runner.os == 'Windows'
217-
with:
218-
drive-size: 8GB
219-
drive-format: ReFS
220-
env-mapping: |
221-
CARGO_HOME,{{ DEV_DRIVE }}/.cargo
222-
RUSTUP_HOME,{{ DEV_DRIVE }}/.rustup
223-
224201
- run: |
225202
brew install rustup
226203
rustup install stable

0 commit comments

Comments
 (0)