Skip to content

Commit e387052

Browse files
Boshenclaude
andcommitted
ci: move if conditions before strategy block
The if condition was placed between strategy and runs-on which may cause YAML parsing issues. Move it to the standard position before strategy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7202f9f commit e387052

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

.github/workflows/ci.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,12 @@ jobs:
6868
github-token: ${{ secrets.GITHUB_TOKEN }}
6969
test:
7070
needs: detect-changes
71+
if: |
72+
needs.detect-changes.outputs.code-changed == 'true' && (
73+
matrix.os == 'ubuntu-latest' ||
74+
github.event_name != 'pull_request' ||
75+
contains(github.event.pull_request.labels.*.name, 'ci: full')
76+
)
7177
name: Test
7278
strategy:
7379
fail-fast: false
@@ -79,12 +85,6 @@ jobs:
7985
target: x86_64-pc-windows-msvc
8086
- os: macos-latest
8187
target: aarch64-apple-darwin
82-
if: |
83-
needs.detect-changes.outputs.code-changed == 'true' && (
84-
matrix.os == 'ubuntu-latest' ||
85-
github.event_name != 'pull_request' ||
86-
contains(github.event.pull_request.labels.*.name, 'ci: full')
87-
)
8888
runs-on: ${{ matrix.os }}
8989
steps:
9090
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
@@ -195,6 +195,10 @@ jobs:
195195
196196
cli-e2e-test:
197197
name: CLI E2E test
198+
if: |
199+
matrix.os == 'ubuntu-latest' ||
200+
github.event_name != 'pull_request' ||
201+
contains(github.event.pull_request.labels.*.name, 'ci: full')
198202
needs:
199203
- download-previous-rolldown-binaries
200204
strategy:
@@ -204,10 +208,6 @@ jobs:
204208
- os: ubuntu-latest
205209
- os: macos-latest
206210
- os: windows-latest
207-
if: |
208-
matrix.os == 'ubuntu-latest' ||
209-
github.event_name != 'pull_request' ||
210-
contains(github.event.pull_request.labels.*.name, 'ci: full')
211211
runs-on: ${{ matrix.os }}
212212
steps:
213213
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1

0 commit comments

Comments
 (0)