Merge branch 'main' into fix-type-check-errors

fengmk2 · web-flow · commit ea8bcb60053c · 2026-03-20T22:47:31.000+08:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -72,11 +72,11 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - os: ubuntu-latest
+          - os: namespace-profile-linux-x64-default
             target: x86_64-unknown-linux-gnu
           - os: windows-latest
             target: x86_64-pc-windows-msvc
-          - os: macos-latest
+          - os: namespace-profile-mac-default
             target: aarch64-apple-darwin
     runs-on: ${{ matrix.os }}
     steps:
@@ -100,7 +100,7 @@ jobs:
           target-dir: ${{ runner.os == 'Windows' && format('{0}/target', env.DEV_DRIVE) || '' }}
 
       - run: rustup target add x86_64-unknown-linux-musl
-        if: ${{ matrix.os == 'ubuntu-latest' }}
+        if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' }}
 
       - run: cargo check --all-targets --all-features
         env:
@@ -114,7 +114,7 @@ jobs:
     needs: detect-changes
     if: needs.detect-changes.outputs.code-changed == 'true'
     name: Lint
-    runs-on: ubuntu-latest
+    runs-on: namespace-profile-linux-x64-default
     steps:
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
       - uses: ./.github/actions/clone
@@ -146,7 +146,7 @@ jobs:
 
   run:
     name: Run task
-    runs-on: ubuntu-latest
+    runs-on: namespace-profile-linux-x64-default
     needs:
       - download-previous-rolldown-binaries
     steps:
@@ -194,8 +194,8 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - os: ubuntu-latest
-          - os: macos-latest
+          - os: namespace-profile-linux-x64-default
+          - os: namespace-profile-mac-default
           - os: windows-latest
     runs-on: ${{ matrix.os }}
     steps:
@@ -232,10 +232,10 @@ jobs:
       - name: Build with upstream
         uses: ./.github/actions/build-upstream
         with:
-          target: ${{ matrix.os == 'ubuntu-latest' && 'x86_64-unknown-linux-gnu' ||  matrix.os == 'windows-latest' && 'x86_64-pc-windows-msvc' || 'aarch64-apple-darwin' }}
+          target: ${{ matrix.os == 'namespace-profile-linux-x64-default' && 'x86_64-unknown-linux-gnu' ||  matrix.os == 'windows-latest' && 'x86_64-pc-windows-msvc' || 'aarch64-apple-darwin' }}
 
       - name: Check TypeScript types
-        if: ${{ matrix.os == 'ubuntu-latest' }}
+        if: ${{ matrix.os == 'namespace-profile-linux-x64-default' }}
         run: pnpm tsgo
 
       - name: Install Global CLI vp
@@ -577,7 +577,7 @@ jobs:
     name: Local CLI `vp install` E2E test
     needs:
       - download-previous-rolldown-binaries
-    runs-on: ubuntu-latest
+    runs-on: namespace-profile-linux-x64-default
     # Run if: not a PR, OR PR has 'test: install-e2e' label
     if: >-
       github.event_name != 'pull_request' ||
diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
@@ -264,6 +264,27 @@ jobs:
               vp check --fix
               vp run check
               vp run test
+          - name: reactive-resume
+            node-version: 24
+            command: |
+              vp fmt
+              vp lint --type-aware
+              vp build
+              vp test
+          - name: yaak
+            node-version: 24
+            command: |
+              vp fmt --ignore-path .oxfmtignore
+              # FIXME: type-aware lint fails with "Invalid tsconfig" without full Rust/wasm bootstrap
+              vp lint || true
+              vp test
+          - name: npmx.dev
+            node-version: 24
+            command: |
+              vp fmt
+              vp run lint
+              vp run test:types
+              vp test --project unit
         exclude:
           # frm-stack uses Docker (testcontainers) which doesn't work the same way on Windows
           - os: windows-latest
@@ -277,6 +298,14 @@ jobs:
           - os: windows-latest
             project:
               name: vinext
+          # yaak is a Tauri app with Rust/wasm deps
+          - os: windows-latest
+            project:
+              name: yaak
+          # npmx.dev is a Nuxt app, ubuntu-only for now
+          - os: windows-latest
+            project:
+              name: npmx.dev
 
     steps:
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
diff --git a/README.md b/README.md
@@ -204,3 +204,7 @@ Or, if you are using Yarn:
   "vitest": "npm:@voidzero-dev/vite-plus-test@latest"
 }
 ```
+
+## Sponsors
+
+Thanks to [namespace.so](https://namespace.so) for powering our CI/CD pipelines with fast, free macOS and Linux runners.
diff --git a/ecosystem-ci/repo.json b/ecosystem-ci/repo.json
@@ -73,5 +73,23 @@
     "branch": "main",
     "hash": "f78dd2b39f5b02242417e0a684b1f2f55d3dbdff",
     "forceFreshMigration": true
+  },
+  "reactive-resume": {
+    "repository": "https://github.com/amruthpillai/reactive-resume.git",
+    "branch": "main",
+    "hash": "f4e2d05f25539ba64a97368f6e35b33b2a7bed05",
+    "forceFreshMigration": true
+  },
+  "yaak": {
+    "repository": "https://github.com/mountain-loop/yaak.git",
+    "branch": "main",
+    "hash": "b4a1c418bb3f923858dd55729f585e189327a038",
+    "forceFreshMigration": true
+  },
+  "npmx.dev": {
+    "repository": "https://github.com/npmx-dev/npmx.dev.git",
+    "branch": "main",
+    "hash": "230b7c7ddb6bb8551ce797144f0ce0f047ff8d7d",
+    "forceFreshMigration": true
   }
 }
diff --git a/packages/cli/README.md b/packages/cli/README.md
@@ -202,3 +202,7 @@ Or, if you are using Yarn:
   "vitest": "npm:@voidzero-dev/vite-plus-test@latest"
 }
 ```
+
+## Sponsors
+
+Thanks to [namespace.so](https://namespace.so) for powering our CI/CD pipelines with fast, free macOS and Linux runners.
diff --git a/packages/cli/snap-tests-global/migration-merge-vite-config-ts/package.json b/packages/cli/snap-tests-global/migration-merge-vite-config-ts/package.json
@@ -17,6 +17,7 @@
   },
   "devDependencies": {
     "@vitejs/plugin-react": "^4.2.0",
+    "@vitest/browser-playwright": "^4.0.0",
     "oxfmt": "1",
     "oxlint": "1",
     "vite": "^7.0.0",
diff --git a/packages/cli/snap-tests-global/migration-monorepo-pnpm-overrides-dependency-selector/package.json b/packages/cli/snap-tests-global/migration-monorepo-pnpm-overrides-dependency-selector/package.json
@@ -5,6 +5,7 @@
     "dev": "vite"
   },
   "devDependencies": {
+    "@vitejs/plugin-react": "catalog:",
     "vite": "catalog:"
   },
   "packageManager": "pnpm@10.20.0+sha512.cf9998222162dd85864d0a8102e7892e7ba4ceadebbf5a31f9c2fce48dfce317a9c53b9f6464d1ef9042cba2e02ae02a9f7c143a2b438cd93c91840f0192b9dd",
diff --git a/packages/cli/snap-tests-global/migration-monorepo-pnpm-overrides-dependency-selector/snap.txt b/packages/cli/snap-tests-global/migration-monorepo-pnpm-overrides-dependency-selector/snap.txt
@@ -26,6 +26,7 @@ export default defineConfig({
     "prepare": "vp config"
   },
   "devDependencies": {
+    "@vitejs/plugin-react": "catalog:",
     "vite": "catalog:",
     "vite-plus": "catalog:"
   },
diff --git a/packages/cli/snap-tests-global/migration-monorepo-pnpm/package.json b/packages/cli/snap-tests-global/migration-monorepo-pnpm/package.json
@@ -16,6 +16,7 @@
     "testnpm2": "1.0.0"
   },
   "devDependencies": {
+    "@vitejs/plugin-react": "catalog:",
     "oxfmt": "catalog:",
     "oxlint": "catalog:",
     "vite": "catalog:",
diff --git a/packages/cli/snap-tests-global/migration-monorepo-pnpm/snap.txt b/packages/cli/snap-tests-global/migration-monorepo-pnpm/snap.txt
@@ -62,6 +62,7 @@ cat: .oxfmtrc.json: No such file or directory
     "testnpm2": "1.0.0"
   },
   "devDependencies": {
+    "@vitejs/plugin-react": "catalog:",
     "vite": "catalog:",
     "vitest": "catalog:",
     "vite-plus": "catalog:"
diff --git a/packages/cli/snap-tests-global/migration-monorepo-yarn4/package.json b/packages/cli/snap-tests-global/migration-monorepo-yarn4/package.json
@@ -19,6 +19,7 @@
     "testnpm2": "1.0.0"
   },
   "devDependencies": {
+    "@vitejs/plugin-react": "catalog:",
     "oxfmt": "catalog:",
     "oxlint": "catalog:",
     "vite": "catalog:",
diff --git a/packages/cli/snap-tests-global/migration-monorepo-yarn4/snap.txt b/packages/cli/snap-tests-global/migration-monorepo-yarn4/snap.txt
@@ -53,6 +53,7 @@ cat: .oxlintrc.json: No such file or directory
     "testnpm2": "1.0.0"
   },
   "devDependencies": {
+    "@vitejs/plugin-react": "catalog:",
     "vite": "catalog:",
     "vitest": "catalog:",
     "vite-plus": "catalog:"
diff --git a/packages/cli/src/migration/__tests__/compat.spec.ts b/packages/cli/src/migration/__tests__/compat.spec.ts
@@ -0,0 +1,50 @@
+import { describe, expect, it } from 'vitest';
+
+import { checkManualChunksCompat } from '../compat.js';
+import { createMigrationReport } from '../report.js';
+
+describe('checkManualChunksCompat', () => {
+  it('should warn when manualChunks is an object', () => {
+    const report = createMigrationReport();
+    checkManualChunksCompat({ manualChunks: { react: ['react', 'react-dom'] } }, report);
+    expect(report.warnings).toHaveLength(1);
+    expect(report.warnings[0]).toContain('Object-form');
+    expect(report.warnings[0]).toContain('codeSplitting');
+  });
+
+  it('should not warn when manualChunks is a function', () => {
+    const report = createMigrationReport();
+    checkManualChunksCompat({ manualChunks: () => undefined }, report);
+    expect(report.warnings).toHaveLength(0);
+  });
+
+  it('should not warn when manualChunks is not set', () => {
+    const report = createMigrationReport();
+    checkManualChunksCompat({}, report);
+    expect(report.warnings).toHaveLength(0);
+  });
+
+  it('should not warn when output is undefined', () => {
+    const report = createMigrationReport();
+    checkManualChunksCompat(undefined, report);
+    expect(report.warnings).toHaveLength(0);
+  });
+
+  it('should handle array of outputs', () => {
+    const report = createMigrationReport();
+    checkManualChunksCompat(
+      [{ manualChunks: () => undefined }, { manualChunks: { vendor: ['lodash'] } }],
+      report,
+    );
+    expect(report.warnings).toHaveLength(1);
+  });
+
+  it('should only add one warning for multiple object-form outputs', () => {
+    const report = createMigrationReport();
+    checkManualChunksCompat(
+      [{ manualChunks: { react: ['react'] } }, { manualChunks: { lodash: ['lodash'] } }],
+      report,
+    );
+    expect(report.warnings).toHaveLength(1);
+  });
+});
diff --git a/packages/cli/src/migration/bin.ts b/packages/cli/src/migration/bin.ts
@@ -540,6 +540,22 @@ function showMigrationSummary(options: {
   }
 }
 
+async function checkRolldownCompatibility(rootDir: string, report: MigrationReport): Promise<void> {
+  try {
+    const { resolveConfig } = await import('../index.js');
+    const { checkManualChunksCompat } = await import('./compat.js');
+    // Use 'runner' configLoader to avoid Rolldown bundling the config file,
+    // which prints UNRESOLVED_IMPORT warnings that cannot be suppressed via logLevel.
+    const config = await resolveConfig(
+      { root: rootDir, logLevel: 'silent', configLoader: 'runner' },
+      'build',
+    );
+    checkManualChunksCompat(config.build?.rollupOptions?.output, report);
+  } catch {
+    // Config resolution may fail — skip compatibility check silently
+  }
+}
+
 async function executeMigrationPlan(
   workspaceInfoOptional: WorkspaceInfoOptional,
   plan: MigrationPlan,
@@ -637,7 +653,16 @@ async function executeMigrationPlan(
     cancelAndExit('Vite+ cannot automatically migrate this project yet.', 1);
   }
 
-  // 5. ESLint → Oxlint migration (before main rewrite so .oxlintrc.json gets picked up)
+  // 5. Check for Rolldown-incompatible config patterns (root + workspace packages)
+  updateMigrationProgress('Checking config compatibility');
+  await checkRolldownCompatibility(workspaceInfo.rootDir, report);
+  if (workspaceInfo.packages) {
+    for (const pkg of workspaceInfo.packages) {
+      await checkRolldownCompatibility(path.join(workspaceInfo.rootDir, pkg.path), report);
+    }
+  }
+
+  // 6. ESLint → Oxlint migration (before main rewrite so .oxlintrc.json gets picked up)
   if (plan.migrateEslint) {
     updateMigrationProgress('Migrating ESLint');
     const eslintOk = await migrateEslintToOxlint(
@@ -725,6 +750,7 @@ async function executeMigrationPlan(
     installArgs,
     { silent: true },
   );
+
   clearMigrationProgress();
   return {
     installDurationMs: initialInstallSummary.durationMs + finalInstallSummary.durationMs,
@@ -825,7 +851,18 @@ async function main() {
       }
     }
 
-    if (didMigrate) {
+    // Check for Rolldown-incompatible config patterns (root + workspace packages)
+    await checkRolldownCompatibility(workspaceInfoOptional.rootDir, report);
+    if (workspaceInfoOptional.packages) {
+      for (const pkg of workspaceInfoOptional.packages) {
+        await checkRolldownCompatibility(
+          path.join(workspaceInfoOptional.rootDir, pkg.path),
+          report,
+        );
+      }
+    }
+
+    if (didMigrate || report.warnings.length > 0) {
       clearMigrationProgress();
       showMigrationSummary({
         projectRoot: workspaceInfoOptional.rootDir,
diff --git a/packages/cli/src/migration/compat.ts b/packages/cli/src/migration/compat.ts
@@ -0,0 +1,19 @@
+import { addMigrationWarning, type MigrationReport } from './report.js';
+
+/**
+ * Check for Rolldown-incompatible manualChunks config patterns.
+ */
+export function checkManualChunksCompat(output: unknown, report: MigrationReport): void {
+  const outputs = Array.isArray(output) ? output : output ? [output] : [];
+  for (const out of outputs) {
+    if (out.manualChunks != null && typeof out.manualChunks !== 'function') {
+      addMigrationWarning(
+        report,
+        'Object-form `build.rollupOptions.output.manualChunks` is not supported by Rolldown. ' +
+          'Convert it to function form or use `build.rolldownOptions.output.codeSplitting`. ' +
+          'See: https://rolldown.rs/options/output#manualchunks and https://rolldown.rs/in-depth/manual-code-splitting',
+      );
+      break;
+    }
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -204,3 +204,7 @@ Or, if you are using Yarn:`
`204`	`204`	`"vitest": "npm:@voidzero-dev/vite-plus-test@latest"`
`205`	`205`	`}`
`206`	`206`	```
	`207`	`+`
	`208`	`+## Sponsors`
	`209`	`+`
	`210`	`+Thanks to [namespace.so](https://namespace.so) for powering our CI/CD pipelines with fast, free macOS and Linux runners.`
Original file line number	Diff line number	Diff line change
`@@ -202,3 +202,7 @@ Or, if you are using Yarn:`
`202`	`202`	`"vitest": "npm:@voidzero-dev/vite-plus-test@latest"`
`203`	`203`	`}`
`204`	`204`	```
	`205`	`+`
	`206`	`+## Sponsors`
	`207`	`+`
	`208`	`+Thanks to [namespace.so](https://namespace.so) for powering our CI/CD pipelines with fast, free macOS and Linux runners.`