refactor(config): simplify pre-commit hook setup with ensurePreCommitHook

- Extract ensurePreCommitHook() to encapsulate staged config + hook
  creation, replacing 3 separate imported functions
- Guard hook creation on install() success to skip when hooks are
  disabled or git is unavailable
- Extract DEFAULT_STAGED_CONFIG constant to deduplicate the default
- Remove redundant existsSync guard (createPreCommitHook handles it)

Author: fengmk2

packages/cli/src/config/bin.ts

@@ -10,11 +10,7 @@ import { join } from 'node:path';
 import mri from 'mri';
 
 import { vitePlusHeader } from '../../binding/index.js';
-import {
-  createPreCommitHook,
-  hasStagedConfigInViteConfig,
-  mergeStagedConfigToViteConfig,
-} from '../migration/migrator.js';
+import { ensurePreCommitHook } from '../migration/migrator.js';
 import { updateExistingAgentInstructions } from '../utils/agent.js';
 import { renderCliDoc } from '../utils/help.js';
 import { defaultInteractive, promptGitHooks } from '../utils/prompts.js';
@@ -81,13 +77,10 @@ async function main() {
       }
     }
 
-    // Create pre-commit hook if missing, and ensure staged config exists
-    const preCommitPath = join(root, hooksDir, 'pre-commit');
-    if (!existsSync(preCommitPath)) {
-      if (!hasStagedConfigInViteConfig(root)) {
-        mergeStagedConfigToViteConfig(root, { '*': 'vp check --fix' }, true);
-      }
-      createPreCommitHook(root, hooksDir);
+    // Only create pre-commit hook when install() succeeded (empty message).
+    // Skip when hooks were disabled or git is unavailable.
+    if (!message) {
+      ensurePreCommitHook(root, hooksDir);
     }
   }
 

packages/cli/src/migration/migrator.ts

@@ -1689,7 +1689,7 @@ export function setupGitHooks(
     const pkgData = readJsonFile<{ 'lint-staged'?: Record<string, string | string[]> }>(
       packageJsonPath,
     );
-    const stagedConfig = pkgData?.['lint-staged'] ?? { '*': 'vp check --fix' };
+    const stagedConfig = pkgData?.['lint-staged'] ?? DEFAULT_STAGED_CONFIG;
     const updated = rewriteScripts(JSON.stringify(stagedConfig), readRulesYaml());
     const finalConfig: Record<string, string | string[]> = updated
       ? JSON.parse(updated)
@@ -1822,6 +1822,20 @@ const STALE_LINT_STAGED_PATTERNS = [
   /^((?:[A-Z_][A-Z0-9_]*(?:=\S*)?\s+)*)lint-staged\b/,
 ];
 
+const DEFAULT_STAGED_CONFIG: Record<string, string> = { '*': 'vp check --fix' };
+
+/**
+ * Ensure the pre-commit hook exists with `vp staged`, and that
+ * vite.config.ts contains a `staged` block (using the default config
+ * if none is present). Called by `vp config` after hook installation.
+ */
+export function ensurePreCommitHook(projectPath: string, dir = '.vite-hooks'): void {
+  if (!hasStagedConfigInViteConfig(projectPath)) {
+    mergeStagedConfigToViteConfig(projectPath, DEFAULT_STAGED_CONFIG, true);
+  }
+  createPreCommitHook(projectPath, dir);
+}
+
 export function createPreCommitHook(projectPath: string, dir = '.vite-hooks'): void {
   const huskyDir = path.join(projectPath, dir);
   fs.mkdirSync(huskyDir, { recursive: true });