Skip to content

Commit f745218

Browse files
committed
ci(test-vp-create): scope remote-vite-react-ts matrix to pnpm
The newly added `remote-vite-react-ts` matrix entry passes on pnpm but fails on npm/yarn/bun with ERR_PNPM_NO_MATCHING_VERSION for @voidzero-dev/vite-plus-core@0.0.0 — even in the (npm) job. Root cause: create-vite@9.0.5 writes `"packageManager": "pnpm@..."` into the scaffolded package.json, which `vp install` follows over the `--package-manager` CLI flag. Combined with the local-tarball overrides CI uses (which are written in a form pnpm-standalone won't consult on the second install), install #2 falls back to the npm registry for vite-plus-core@0.0.0 and fails. Wiring --package-manager through remote-template scaffolds (and updating the overrides injection to match) is separate infrastructure work. For now, exclude npm/yarn/bun combinations via a matrix `exclude` so the regression coverage we gain on pnpm is still in CI without red builds on the other three.
1 parent d776e56 commit f745218

1 file changed

Lines changed: 17 additions & 0 deletions

File tree

.github/workflows/test-vp-create.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,23 @@ jobs:
151151
- npm
152152
- yarn
153153
- bun
154+
# Remote create-vite scaffolds bake `"packageManager": "pnpm@..."`
155+
# into the generated package.json, which `vp install` follows over
156+
# the --package-manager CLI flag. Combined with local-tarball
157+
# overrides in CI, that makes non-pnpm paths resolve
158+
# @voidzero-dev/vite-plus-core@0.0.0 from the npm registry and
159+
# fail. Scope this matrix entry to pnpm until the remote-template
160+
# install-flag propagation is sorted out separately.
161+
exclude:
162+
- template:
163+
name: remote-vite-react-ts
164+
package-manager: npm
165+
- template:
166+
name: remote-vite-react-ts
167+
package-manager: yarn
168+
- template:
169+
name: remote-vite-react-ts
170+
package-manager: bun
154171
env:
155172
VP_OVERRIDE_PACKAGES: '{"vite":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-core-0.0.0.tgz","vitest":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-test-0.0.0.tgz","@voidzero-dev/vite-plus-core":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-core-0.0.0.tgz","@voidzero-dev/vite-plus-test":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-test-0.0.0.tgz"}'
156173
VP_VERSION: 'file:${{ github.workspace }}/tmp/tgz/vite-plus-0.0.0.tgz'

0 commit comments

Comments
 (0)