Skip to content

Commit fcd4a97

Browse files
committed
fix(migrate): clear the spinner before the --full setup prompts
The "Rewriting toolchain imports" spinner, started before finalizeCoreMigrationForExistingVitePlus, stayed active through collectMigrationSetupPlan, so in `--full` mode the git-hooks setup prompt rendered on top of the still-ticking spinner line. Clear the spinner right after finalizeCore finishes; that also makes the early-return clear redundant, so consolidate to one clear point. Claude-Session: https://claude.ai/code/session_01DQhS6o1fyQd1yjiee6W8jR
1 parent 8a802d8 commit fcd4a97

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • packages/cli/src/migration

packages/cli/src/migration/bin.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1179,6 +1179,11 @@ async function main() {
11791179
didMigrate = true;
11801180
}
11811181

1182+
// finalizeCore has finished; stop the spinner before the interactive setup
1183+
// prompts below (collectMigrationSetupPlan / framework shims, in --full mode)
1184+
// so they don't render on top of the still-running progress line.
1185+
clearMigrationProgress();
1186+
11821187
// On an existing Vite+ project, `vp migrate` only upgrades the toolchain
11831188
// version. The full setup bucket (hooks, editor, agent files, ESLint/Prettier
11841189
// migration, framework shims, tsconfig baseUrl, .node-version) runs only with
@@ -1203,7 +1208,6 @@ async function main() {
12031208
? hasExistingVitePlusMigrationCandidates(workspaceInfoOptional, options)
12041209
: hasExplicitExistingVitePlusSetupRequest(options))
12051210
) {
1206-
clearMigrationProgress();
12071211
if (skippedSetupCandidates) {
12081212
log(FULL_MIGRATION_HINT);
12091213
}

0 commit comments

Comments
 (0)