Merge branch 'main' into feat/migrate-volta-to-node-version

Author: naokihaba

.claude/skills/bump-vite-task/SKILL.md

@@ -59,7 +59,23 @@ To update snap tests:
 
 Snap test files are at `packages/cli/snap-tests/*/snap.txt` and `packages/cli/snap-tests-global/*/snap.txt`.
 
-### 7. Create the PR
+### 7. Review changelog and update docs
+
+- Fetch the vite-task `CHANGELOG.md` diff between old and new commits to see what changed:
+  ```
+  https://raw.githubusercontent.com/voidzero-dev/vite-task/<new-hash>/CHANGELOG.md
+  ```
+- Review each changelog entry and determine if it affects user-facing behavior: new CLI options, changed defaults, new config fields, removed features, etc.
+- The changelog contains links to the corresponding vite-task PRs. For complex changes, check the PR description and code diff (especially any docs changes in the PR) to understand the full scope of the change.
+- If user-facing changes are found, update the relevant docs in `docs/` (e.g., `docs/guide/`, `docs/config/`).
+- Common doc updates include:
+  - **New CLI flags/options**: Update the relevant config doc (e.g., `docs/config/run.md`, `docs/config/build.md`)
+  - **New features or commands**: Add or update the relevant guide page (e.g., `docs/guide/cache.md`)
+  - **Changed defaults or behavior**: Update any docs that describe the old behavior
+  - **Removed/deprecated options**: Remove or mark as deprecated in the relevant docs
+- If no user-facing changes are found, skip this step.
+
+### 8. Create the PR
 
 - Commit message: `chore: bump vite-task to <short-hash>`
 - PR title: `chore: bump vite-task to <short-hash>`
@@ -68,7 +84,7 @@ Snap test files are at `packages/cli/snap-tests/*/snap.txt` and `packages/cli/sn
   https://github.com/voidzero-dev/vite-task/compare/<old-hash>...<new-hash>#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
   ```
 
-### 8. Verify CI
+### 9. Verify CI
 
 Wait for CI and ensure the `done` check passes. Key checks to monitor:
 

.github/actions/build-upstream/action.yml

@@ -27,6 +27,12 @@ runs:
       run: |
         echo "key=napi-binding-v3-${{ inputs.target }}-${{ env.RELEASE_BUILD }}-${{ env.DEBUG }}-${{ env.VERSION }}-${{ env.NPM_TAG }}-${{ hashFiles('packages/tools/.upstream-versions.json', 'Cargo.lock', 'crates/**/*.rs', 'crates/*/Cargo.toml', 'packages/cli/binding/**/*.rs', 'packages/cli/binding/Cargo.toml', 'Cargo.toml', '.cargo/config.toml', 'packages/cli/package.json', 'packages/cli/build.ts') }}" >> $GITHUB_OUTPUT
 
+    # Resolve the Rust target directory (CARGO_TARGET_DIR from setup-rust, or default "target")
+    - name: Resolve Rust target directory
+      id: rust-target
+      shell: bash
+      run: echo "dir=${CARGO_TARGET_DIR:-target}" >> $GITHUB_OUTPUT
+
     # Cache NAPI bindings and Rust CLI binary (the slow parts, especially on Windows)
     - name: Restore NAPI binding cache
       id: cache-restore
@@ -38,9 +44,9 @@ runs:
           packages/cli/binding/index.d.ts
           packages/cli/binding/index.cjs
           packages/cli/binding/index.d.cts
-          target/${{ inputs.target }}/release/vp
-          target/${{ inputs.target }}/release/vp.exe
-          target/${{ inputs.target }}/release/vp-shim.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp-shim.exe
         key: ${{ steps.cache-key.outputs.key }}
 
     # Apply Vite+ branding patches to vite source (CI checks out
@@ -147,9 +153,9 @@ runs:
           packages/cli/binding/index.d.ts
           packages/cli/binding/index.cjs
           packages/cli/binding/index.d.cts
-          target/${{ inputs.target }}/release/vp
-          target/${{ inputs.target }}/release/vp.exe
-          target/${{ inputs.target }}/release/vp-shim.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp-shim.exe
         key: ${{ steps.cache-key.outputs.key }}
 
     # Build vite-plus TypeScript after native bindings are ready

.github/actions/clone/action.yml

@@ -31,13 +31,13 @@ runs:
         node -e "console.log('ECOSYSTEM_CI_PROJECT_REPOSITORY=' + require('./ecosystem-ci/repo.json')['${{ inputs.ecosystem-ci-project }}'].repository.replace('https://github.com/', '').replace('.git', ''))" >> $GITHUB_OUTPUT
         echo "ECOSYSTEM_CI_PROJECT_PATH=${{ runner.temp }}/vite-plus-ecosystem-ci/${{ inputs.ecosystem-ci-project }}" >> $GITHUB_OUTPUT
 
-    - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+    - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       with:
         repository: rolldown/rolldown
         path: rolldown
         ref: ${{ steps.upstream-versions.outputs.ROLLDOWN_HASH }}
 
-    - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+    - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       with:
         repository: vitejs/vite
         path: vite

.github/scripts/retry-failed-snap-tests.sh

@@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+# Retry only the snap test cases whose snap.txt changed, up to max_retries times.
+# Usage: retry-failed-snap-tests.sh [max_retries]
+set -euo pipefail
+
+max_retries=${1:-2}
+
+for retry in $(seq 1 "$max_retries"); do
+  changed=$(git diff --name-only -- 'packages/cli/snap-tests*/*/snap.txt')
+  if [ -z "$changed" ]; then
+    exit 0
+  fi
+
+  echo "::warning::Snapshot diff detected, retry $retry/$max_retries for failed cases..."
+  git diff --stat -- 'packages/cli/snap-tests*/*/snap.txt'
+
+  failed_local=$(echo "$changed" | grep -v 'snap-tests-global/' | sed -E 's|packages/cli/snap-tests/([^/]+)/.*|\1|' | sort -u || true)
+  failed_global=$(echo "$changed" | grep 'snap-tests-global/' | sed -E 's|packages/cli/snap-tests-global/([^/]+)/.*|\1|' | sort -u || true)
+
+  echo "$changed" | xargs git checkout --
+
+  for name in $failed_local; do
+    echo "Retrying local snap test: $name"
+    RUST_BACKTRACE=1 pnpm -F ./packages/cli snap-test-local "$name"
+  done
+  for name in $failed_global; do
+    echo "Retrying global snap test: $name"
+    RUST_BACKTRACE=1 pnpm -F ./packages/cli snap-test-global "$name"
+  done
+done
+
+# Final check after all retries
+if ! git diff --quiet -- 'packages/cli/snap-tests*/*/snap.txt'; then
+  echo "::error::Snapshot diff detected after $max_retries retries. Run 'pnpm -F vite-plus snap-test' locally and commit the updated snap.txt files."
+  git diff --stat
+  git diff
+  exit 1
+fi