Fish shell: PATH order check warning when installed in conf.d/vite-plus.fish

[Loongphy]

Describe the bug

On my system, Vite+ installed this file: ~/.config/fish/conf.d/vite-plus.fish

# Vite+ bin (https://viteplus.dev)
source "$HOME/.vite-plus/env.fish"

However, vp env doctor reports:

⚠ vp in PATH at position 1
note: For best results, bin should be first in PATH.

If I put:

source "$HOME/.vite-plus/env.fish"

near the end of ~/.config/fish/config.fish, the warning disappears and vp works as expected.

Reproduction

null

Steps to reproduce

Run vp env doctor

System Info

VITE+ - The Unified Toolchain for the Web

Environment:
  Version  24.14.0
  Source   lts

Tool Paths:
  node  /root/.vite-plus/js_runtime/node/24.14.0/bin/node
  npm   /root/.vite-plus/js_runtime/node/24.14.0/bin/npm
  npx   /root/.vite-plus/js_runtime/node/24.14.0/bin/npx



VITE+ - The Unified Toolchain for the Web

vp v0.1.13

Local vite-plus:
  vite-plus  Not found

Tools:
  vite             Not found
  rolldown         Not found
  vitest           Not found
  oxfmt            Not found
  oxlint           Not found
  oxlint-tsgolint  Not found
  tsdown           Not found

Environment:
  Package manager  Not found
  Node.js          v24.14.0

Used Package Manager

npm

Logs

Validations

• Read the Contributing Guidelines.
• Check that there isn't already an issue for the same bug.
• Confirm this is a Vite+ issue and not an upstream issue (Vite, Vitest, tsdown, Rolldown, or Oxc).
• The provided reproduction is a minimal reproducible example.

[claude]

Analysis

Understanding the issue:

Fish shell loads ~/.config/fish/conf.d/ files alphabetically before ~/.config/fish/config.fish. The conf.d/vite-plus.fish file sources env.fish, which prepends the vp bin directory to PATH with set -gx PATH __VP_BIN__ $PATH. However, if config.fish (or a conf.d file alphabetically later than vite-plus.fish) also prepends something to PATH afterward, the vp bin gets pushed down — which is why vp env doctor warns "in PATH at position 1".

The user's fix (sourcing at the end of config.fish) works precisely because config.fish runs last in fish's startup sequence, so nothing else can prepend before it afterward.

Relevant files:

• packages/cli/install.sh (lines 398–410): Creates conf.d/vite-plus.fish for fish shell installs
• crates/vite_global_cli/src/commands/env/setup.rs (lines 497–529): Generates env.fish with set -gx PATH __VP_BIN__ $PATH
• crates/vite_global_cli/src/commands/env/doctor.rs (lines 400–460): check_path() warns when vp bin is not at position 0
• crates/vite_global_cli/src/commands/implode.rs (lines 17–24): Cleans up conf.d/vite-plus.fish on uninstall

Is this fixable? Yes.

---

Implementation Plan

Root cause

Fish startup order: conf.d/*.fish (alphabetical) → config.fish. Installing into conf.d/vite-plus.fish means any PATH modification in config.fish (e.g., from nvm, fnm, homebrew, or user config) runs after and can push vp bin down.

Fix: Change fish install target from conf.d to config.fish

Instead of creating a new conf.d/vite-plus.fish file, append the source line to the end of ~/.config/fish/config.fish — matching exactly the workaround the user already found.

Step 1 — packages/cli/install.sh (lines 398–410)

Change the fish case from writing to conf.d/vite-plus.fish to appending to config.fish:

*/fish)
  local fish_config_dir="${XDG_CONFIG_HOME:-$HOME/.config}/fish"
  local fish_config="$fish_config_dir/config.fish"
  if grep -q "\.vite-plus/env\.fish" "$fish_config" 2>/dev/null; then
    result=2
  elif [ -f "${fish_config_dir}/conf.d/vite-plus.fish" ]; then
    result=2
  else
    mkdir -p "$fish_config_dir"
    printf '\n# Vite+ bin (https://viteplus.dev)\nsource "%s/env.fish"\n' "$INSTALL_DIR_REF" >> "$fish_config"
    result=0
    SHELL_CONFIG_UPDATED="$fish_config"
  fi
  ;;

Step 2 — crates/vite_global_cli/src/commands/env/doctor.rs

The ALL_SHELL_PROFILES array already includes .config/fish/config.fish, so detection will continue working. No changes needed for check_profile_files.

Step 3 — crates/vite_global_cli/src/commands/implode.rs (lines 17–24)

Add .config/fish/config.fish as a non-snippet entry so vp implode removes the source line for users on the new install path. Keep conf.d/vite-plus.fish for legacy cleanup.

const SHELL_PROFILES: &[(&str, bool)] = &[
    (".zshenv", false),
    (".zshrc", false),
    (".bash_profile", false),
    (".bashrc", false),
    (".profile", false),
    (".config/fish/config.fish", false),          // new: for new installs
    (".config/fish/conf.d/vite-plus.fish", true),  // keep: legacy snippet cleanup
];

Step 4 — crates/vite_global_cli/src/commands/env/setup.rs

If vp env setup also writes fish config (for reinstalls), apply the same change — append to config.fish instead of conf.d.

---

Backward compatibility

• Existing conf.d/vite-plus.fish users are unaffected; that file keeps working.
• vp implode already deletes conf.d/vite-plus.fish as a snippet; no regression there.
• check_profile_files in doctor.rs already covers both config.fish and conf.d/vite-plus.fish.

Potential concern

Some users prefer conf.d to keep config.fish clean. The tradeoff is clean config vs. correct PATH ordering. Since wrong PATH order means shims are bypassed (the tool stops working correctly), correct behavior takes priority.

[nekomoyi]

Fixed by #1140