Skip to content

fix: correctly resolve tsgolint in yarn monorepo packages #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 5 commits into from
Apr 6, 2026
+13 −9
Merged

fix: correctly resolve tsgolint in yarn monorepo packages #1310

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa049f7
Fix the bug
rChaoz Apr 5, 2026
8e7e259
Improve error message when tsgolint executable cannot be resolved
rChaoz Apr 5, 2026
12a0b38
Improvements
rChaoz Apr 5, 2026
1ebb5fa
Merge branch 'main' into fix/tsgolint-yarn-monorepo
rChaoz Apr 5, 2026
f0e68a4
Merge branch 'main' into fix/tsgolint-yarn-monorepo
fengmk2 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions packages/cli/src/resolve-lint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,15 @@ export async function lint(): Promise<{
// On Windows, try .exe first (bun creates .exe), then .cmd (npm/pnpm/yarn create .cmd)
const scriptDir = dirname(fileURLToPath(import.meta.url));
const localBinDir = join(scriptDir, '..', 'node_modules', '.bin');
const cwdBinDir = join(process.cwd(), 'node_modules', '.bin');
oxlintTsgolintPath =
[
join(localBinDir, 'tsgolint.exe'),
join(localBinDir, 'tsgolint.cmd'),
join(cwdBinDir, 'tsgolint.exe'),
join(cwdBinDir, 'tsgolint.cmd'),
].find((p) => existsSync(p)) ?? '';
const oxlintTsgolintPackagePath = dirname(dirname(oxlintTsgolintPath));
const projectBinDir = join(oxlintTsgolintPackagePath, '..', '.bin');
const pathCandidates = [
join(localBinDir, 'tsgolint.exe'),
join(localBinDir, 'tsgolint.cmd'),
join(projectBinDir, 'tsgolint.exe'),
join(projectBinDir, 'tsgolint.cmd'),
];
oxlintTsgolintPath = pathCandidates.find((p) => existsSync(p)) ?? '';
// Bun stores packages in .bun/ cache dirs where the symlinked paths above won't match.
if (!oxlintTsgolintPath) {
try {
Expand All @@ -67,7 +68,10 @@ export async function lint(): Promise<{
}
}
if (!oxlintTsgolintPath) {
oxlintTsgolintPath = join(cwdBinDir, 'tsgolint.cmd');
throw new Error(
'Unable to resolve oxlint-tsgolint executable, tried:\n' +
pathCandidates.map((path) => `- ${path}`).join('\n'),
);
}
const relativePath = relative(process.cwd(), oxlintTsgolintPath);
// Only prepend .\ if it's actually a relative path (not an absolute path returned by relative())
Expand Down
Loading