fix(install): filter KeyEventKind on Windows for arrow key navigation#1362
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
On Windows, crossterm emits both Press and Release events for each key press. Without filtering for Press-only, arrow keys in the `vp i` package manager prompt were processed twice per press (move then move back), making them appear non-functional. Closes #1361
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a94deea. Configure here.
|
windows test pass |
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
This looks sketchy but I trust your codex.
Merge activity
|
2 participants
On Windows, crossterm emits both Press and Release events for each
key press. Without filtering for Press-only, arrow keys in the
vp ipackage manager prompt were processed twice per press (movethen move back), making them appear non-functional.
Closes #1361
Note
Low Risk
Low risk: small, localized change to interactive terminal input handling, primarily affecting Windows key navigation behavior.
Overview
Fixes the interactive package manager selection menu to ignore non-press keyboard events by filtering
crosstermKeyEventKindtoPressbefore handling navigation/selection keys.This prevents double-handling of arrow keys on Windows (where both Press and Release events are emitted), making ↑/↓ navigation behave correctly.
Reviewed by Cursor Bugbot for commit a94deea. Configure here.