feat(deps): upgrade upstream dependencies#1447
Closed
Brooooooklyn wants to merge 2 commits intomainfrom
Closed
Conversation
- rolldown: edec4fa -> v1.0.0-rc.17 (d9d72c3) - tsdown: 0.21.9 -> 0.21.10 - @vitejs/devtools: 0.1.14 -> 0.1.15 Code changes: - Re-merge rolldown workspace into root Cargo.toml: drop removed crates (rolldown_filter_analyzer, rolldown_plugin_vite_asset, rolldown_plugin_vite_asset_import_meta_url, rolldown_plugin_vite_css, rolldown_plugin_vite_css_post, rolldown_plugin_vite_html, rolldown_plugin_vite_html_inline_proxy) and their now-unused transitive deps (css-module-lexer, html5gum, prettyplease, proc-macro2, quote, string_cache, syn); cargo-shear `ignored` list cleared (Cargo.toml). - Add `external` filter to the tsdown bundle step so tsdown's own runtime imports are not inlined (packages/core/build.ts).
✅ Deploy Preview for viteplus-preview canceled.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fengmk2
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rolldowntov1.0.0-rc.17,tsdownto0.21.10, and@vitejs/devtoolsto0.1.15.Cargo.toml: several rolldown crates were removed upstream, so the matching workspace entries and their now-unused transitive deps are dropped and thecargo-shearignore list is cleared.externalfilter to the tsdown bundling step inpackages/core/build.tsso tsdown's runtime imports are not inlined.Dependency updates
rolldownedec4fav1.0.0-rc.17 (d9d72c3)tsdown0.21.90.21.10@vitejs/devtools0.1.140.1.15Unchanged dependencies
vite:v8.0.9 (ce729f5)vitest:4.1.5@oxc-node/cli:0.1.0@oxc-node/core:0.1.0oxfmt:0.46.0oxlint:1.61.0oxlint-tsgolint:0.21.1@oxc-project/runtime:0.127.0@oxc-project/types:0.127.0oxc-minify:0.127.0oxc-parser:0.127.0oxc-transform:0.127.0Code changes
Cargo.toml: Drop the rolldown crates removed upstream (rolldown_filter_analyzer,rolldown_plugin_vite_asset,rolldown_plugin_vite_asset_import_meta_url,rolldown_plugin_vite_css,rolldown_plugin_vite_css_post,rolldown_plugin_vite_html,rolldown_plugin_vite_html_inline_proxy) and their now-unused transitive dependencies (css-module-lexer,html5gum,prettyplease,proc-macro2,quote,string_cache,syn); empty thecargo-shearignoredlist accordingly.packages/core/build.ts: Add anexternalpredicate to the tsdown bundle step so imports starting with thetsdownExternalprefixes are not inlined.packages/core/package.json: Bump@vitejs/devtoolsto^0.1.15,@tsdown/css/@tsdown/exepeer ranges to0.21.10, and updatebundledVersionsforrolldownandtsdown.pnpm-workspace.yaml: Bump thetsdowncatalog entry to^0.21.10.packages/tools/.upstream-versions.json: Record the new rolldown hash.pnpm-lock.yaml: Regenerated to match the version bumps.Build status
sync-remote-and-build: failurebuild-upstream: failureNote
Medium Risk
Moderate risk: bumps core build-time dependencies (
rolldown,tsdown,@vitejs/devtools) and changestsdownbundling externals, which can affect generated artifacts and runtime module resolution.Overview
Upgrades upstream toolchain dependencies, including
rolldownto1.0.0-rc.17,tsdownto0.21.10, and@vitejs/devtoolsto0.1.15, with lockfile/workspace catalog updates.Cleans up the Rust workspace config by dropping now-removed upstream rolldown crates and clearing the
cargo-shearignore list.Adjusts
packages/core/build.tsto marktsdownpeer dependency imports asexternalduring the type-bundle step so those runtime imports are not inlined.Reviewed by Cursor Bugbot for commit 4a2f598. Bugbot is set up for automated code reviews on this repo. Configure here.