Skip to content

fix(check): remove redundant package tsconfigs to unblock single-file lint-staged #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix(check): remove redundant package tsconfigs to unblock single-file lint-staged #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6163f6
fix(check): remove redundant package tsconfigs to unblock single-file…
fengmk2 Apr 24, 2026
2d2a366
fix: restore packages/{core,test}/tsconfig.json — load-bearing for ox…
fengmk2 Apr 24, 2026
a4569c8
fix: tighten packages/{core,test}/tsconfig include so vp lint works o…
fengmk2 Apr 24, 2026
81a14f9
fix: delete packages/{core,test}/tsconfig.json by routing oxnode and …
fengmk2 Apr 24, 2026
60cfabd
Fixup
fengmk2 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/cli/tsconfig.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/core/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ await mergePackageJson();

async function buildVite() {
const newViteRolldownConfig = viteRolldownConfig.map((config) => {
config.tsconfig = join(projectDir, 'tsconfig.json');
config.tsconfig = join(projectDir, '..', '..', 'tsconfig.json');
config.cwd = projectDir;

if (Array.isArray(config.external)) {
Expand Down
3 changes: 2 additions & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"./types/internal/*": null
},
"scripts": {
"build": "oxnode -C dev ./build.ts"
"build": "cross-env OXC_TSCONFIG_PATH=../../tsconfig.json oxnode -C dev ./build.ts"
Copy link
Copy Markdown
Member Author

@fengmk2 fengmk2 Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oxc-project/oxc-node#569 cc @Brooooooklyn

},
"dependencies": {
"@oxc-project/runtime": "catalog:",
Expand All @@ -116,6 +116,7 @@
"@oxc-node/cli": "catalog:",
"@oxc-node/core": "catalog:",
"@vitejs/devtools": "^0.1.15",
"cross-env": "catalog:",
"es-module-lexer": "^1.7.0",
"hookable": "^6.0.1",
"magic-string": "^0.30.21",
Expand Down
9 changes: 0 additions & 9 deletions packages/core/tsconfig.json
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion packages/test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@
}
},
"scripts": {
"build": "oxnode -C dev ./build.ts"
"build": "cross-env OXC_TSCONFIG_PATH=../../tsconfig.json oxnode -C dev ./build.ts"
},
"dependencies": {
"@standard-schema/spec": "^1.1.0",
Expand Down Expand Up @@ -306,6 +306,7 @@
"@vitest/utils": "4.1.5",
"chai": "^6.2.1",
"convert-source-map": "^2.0.0",
"cross-env": "catalog:",
"estree-walker": "^3.0.3",
"expect-type": "^1.2.2",
"magic-string": "^0.30.21",
Expand Down
9 changes: 0 additions & 9 deletions packages/test/tsconfig.json
View file
Open in desktop

This file was deleted.

24 changes: 24 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ catalog:
change-case: ^5.4.4
connect: ^3.7.0
consola: ^3.4.2
cross-env: ^10.1.0
cross-spawn: ^7.0.5
debug: ^4.4.3
dedent: ^1.5.3
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"strict": true,
"target": "esnext",
"types": ["node"],
"verbatimModuleSyntax": true
"verbatimModuleSyntax": true,
"experimentalDecorators": true
},
"exclude": [
"ecosystem-ci",
Expand Down
Loading