fix(env): support PowerShell on non-Windows platforms#1481
fix(env): support PowerShell on non-Windows platforms#1481fengmk2 merged 8 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@nekomoyi Could you add a corresponding test job in our CI? I'm concerned that future code changes might still modify this code without discovering this special logic. |
|
@fengmk2 Thanks. I’ve updated the PowerShell coverage in CI. The PowerShell path in our CLI E2E test can now run cross-platform. PowerShell steps go through the shell env wrapper instead of calling the I also adjusted This fixes the immediate non-Windows pwsh issue, but |
PowerShell is not Windows-only, but
vp env setupwas generating env.ps1 with vp.exe. That breaks pwsh users on non-Windows platforms.Changes
VP_SHELL_PWSH