fix: add vite-plus/pack/client export as tsdown/client equivalent#1501
fix: add vite-plus/pack/client export as tsdown/client equivalent#1501naokihaba wants to merge 7 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
| expect(content).toContain('ImportMeta'); | ||
| expect(content).toContain('glob'); |
There was a problem hiding this comment.
I've added some tests to handle file copying and validation based on tsdown/client.d.ts to make sure everything is working as expected.
https://github.com/rolldown/tsdown/blob/main/client.d.ts#L35-L58
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9de06aa28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@naokihaba I just searched the global code on github again and found that there is already usage of importing Then we can create a new issue to handle the previously unimplemented todo items for tsconfig.json together, and rewrite both |
Thank you for checking! I understand that if these aren't rewritten during migration, they will break once tsdown is removed as a dependency — TypeScript won't be able to find the types, and imports will fail. I'll create a new issue to cover both:
|
resolves #1500