-
Notifications
You must be signed in to change notification settings - Fork 177
fix: add vite-plus/pack/client export as tsdown/client equivalent #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
naokihaba
wants to merge
7
commits into
voidzero-dev:main
Choose a base branch
from
naokihaba:fix/1500
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5789706
feat(tsdown): copy client.d.ts to dist/tsdown for TypeScript bundler …
naokihaba 4d8bb3c
feat(package): add TypeScript types for ./pack/client export
naokihaba 3f29133
test: add test for tsdown client.d.ts inclusion in dist/tsdown
naokihaba e629ea6
feat(tsdown): rewrite tsdown/client reference to vite-plus/pack/client
naokihaba b9de06a
feat: add tsdown/client reference types to migration rewrite tests
naokihaba f824906
feat: add ambient type declarations for tsdown bundler in ./pack/client
naokihaba b31985a
ci: rerun tests
naokihaba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,4 +16,13 @@ describe('build artifacts', () => { | |
| expect(content).toContain('__dirname'); | ||
| expect(content).toContain('__filename'); | ||
| }); | ||
|
|
||
| it('should include tsdown client.d.ts in dist/tsdown for pack/client support', () => { | ||
| const clientPath = path.join(distDir, 'tsdown/client.d.ts'); | ||
| expect(fs.existsSync(clientPath), `${clientPath} should exist`).toBe(true); | ||
|
|
||
| const content = fs.readFileSync(clientPath, 'utf8'); | ||
| expect(content).toContain('ImportMeta'); | ||
| expect(content).toContain('glob'); | ||
|
Comment on lines
+25
to
+26
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've added some tests to handle file copying and validation based on tsdown/client.d.ts to make sure everything is working as expected. https://github.com/rolldown/tsdown/blob/main/client.d.ts#L35-L58 |
||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.