ci: add codiff to ecosystem-ci#1648
Open
fengmk2 wants to merge 3 commits into
Open
Conversation
nkzw-tech/codiff is an Electron diff viewer that already uses vite-plus. Runs `vp run test:all` (which expands to `vp check && vp test` per its `vite.config.ts`) on ubuntu-latest only, matching upstream CI.
✅ Deploy Preview for viteplus-preview canceled.
|
`vp migrate` rewrites package.json without reformatting, so the project's `vp check && vp test` task (vp run test:all) fails on the fmt step. Run `vp fmt` first to normalize the migrated file.
cpojer
approved these changes
May 21, 2026
cpojer
left a comment
cpojer
left a comment
Member
There was a problem hiding this comment.
I don't mind but does Codiff do anything worth testing that's not already covered elsewhere?
Member
Author
|
I don't think so, but I want to add an Electron app as a test case, and I just saw codiff.🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp run test:all(which expands tovp check && vp testvia the task defined in codiff'svite.config.ts) on ubuntu-latest only — matching upstream'stest.ymlworkflow.vite-plus(via catalog), soforceFreshMigration: trueis set sovp migrateperforms a full dependency rewrite rather than skipping.Test plan
codiffmatrix entry on ubuntu-latest