chore(task): exit process in Node.js#199
Merged
Brooooooklyn merged 1 commit intomainfrom Sep 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors exit handling in the CLI by moving process termination from Rust to Node.js. Instead of calling std::process::exit() directly in Rust, the code now returns exit codes that are handled by the Node.js layer.
- Changed Rust function return type from
Result<()>toResult<i32>to return exit codes - Removed direct
std::process::exit()calls in Rust and return exit codes instead - Added exit code handling in Node.js with
process.exit(exitCode)
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/cli/binding/src/lib.rs | Modified run function to return exit codes instead of calling std::process::exit() |
| packages/cli/src/bin.ts | Added .then() handler to receive exit code and call process.exit() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fengmk2
approved these changes
Sep 25, 2025
Member
Author
Merge activity
|
For debugging purpose
ef6e1d3 to
748ad2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For debugging purpose