chore: add in-house detours ffi bindings#207
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4876d60 to
80b7f3c
Compare
c71422a to
ffab252
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the external ms-detours crate with in-house FFI bindings to Microsoft's Detours library, improving build times and enabling cross-compilation.
- Creates a new
fspy_detours_syscrate with raw FFI bindings to Microsoft Detours - Adds Microsoft Detours as a git submodule and builds from source using the
cccrate - Updates all existing imports to use the new in-house bindings instead of
ms-detours
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
crates/fspy_detours_sys/ |
New crate containing FFI bindings, build script, and generated bindings |
crates/fspy_shared/Cargo.toml |
Removes ms-detours dependency and updates winapi to use workspace version |
crates/fspy_preload_windows/ |
Updates imports from ms_detours to fspy_detours_sys and adds new dependency |
crates/fspy/ |
Updates imports and dependency configuration for Windows |
Cargo.toml |
Adds workspace dependencies for the new crate |
.github/workflows/ |
Updates CI workflows to checkout git submodules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ffab252 to
75c1d3c
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 22 out of 23 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f90de79 to
b8f3d04
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 22 out of 23 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|

This PR replaces the external
ms-detourscrate with our own FFI bindings to Microsoft's Detours library. The implementation:fspy_detours_syscrate with raw FFI bindingscccrateThis change improves built times and allows cross-compiling.