Skip to content

style: clippy autofix#210

Merged
Brooooooklyn merged 1 commit intomainfrom
10-03-style_clippy_autofix
Oct 3, 2025
Merged

style: clippy autofix#210
Brooooooklyn merged 1 commit intomainfrom
10-03-style_clippy_autofix

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member Author

Brooooooklyn commented Oct 3, 2025

@Brooooooklyn Brooooooklyn changed the base branch from 10-03-chore_move_all_deps_into_workspace_dependencies to graphite-base/210 October 3, 2025 03:10
@Brooooooklyn Brooooooklyn force-pushed the 10-03-style_clippy_autofix branch from ce998b2 to eb5a949 Compare October 3, 2025 03:11
@graphite-app graphite-app Bot changed the base branch from graphite-base/210 to main October 3, 2025 03:12
@Brooooooklyn Brooooooklyn force-pushed the 10-03-style_clippy_autofix branch from eb5a949 to 516d13b Compare October 3, 2025 03:12
Copilot AI review requested due to automatic review settings October 3, 2025 05:39
@Brooooooklyn Brooooooklyn force-pushed the 10-03-style_clippy_autofix branch from 516d13b to b2265ae Compare October 3, 2025 05:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies automatic clippy fixes to improve Rust code style and idioms throughout the codebase. The changes focus on replacing redundant patterns with more idiomatic Rust constructs.

  • Replaces explicit return statements with implicit returns
  • Converts format!() calls with static strings to use string interpolation
  • Replaces verbose patterns with more concise alternatives (e.g., map_or_else, inspect_err)

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/cli/binding/src/lib.rs Removes unnecessary explicit return statement
crates/vite_task/src/ui.rs Updates format strings to use string interpolation and replaces verbose patterns
crates/vite_task/src/schedule.rs Updates format string and adds backticks around code reference
crates/vite_task/src/lib.rs Uses inspect_err instead of map_err and removes unnecessary reference
crates/vite_task/src/fs.rs Uses Self:: instead of full type name for static method call
crates/vite_task/src/execute.rs Uses map_or_else and replaces "".to_string() with String::new()
crates/vite_task/src/config/mod.rs Adds const qualifier to function that can be evaluated at compile time
crates/vite_package_manager/src/request.rs Updates format string to use string interpolation
crates/vite_package_manager/src/package_manager.rs Changes string literal from double quotes to single quotes for character literal

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Brooooooklyn Brooooooklyn merged commit 8edc304 into main Oct 3, 2025
9 checks passed
Copy link
Copy Markdown
Member Author

Merge activity

@Brooooooklyn Brooooooklyn deleted the 10-03-style_clippy_autofix branch October 3, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants