style: fix clippy::struct_field_names#212
Merged
Brooooooklyn merged 1 commit intomainfrom Oct 3, 2025
Merged
Conversation
This was referenced Oct 3, 2025
Merged
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e7a71c1 to
780dde0
Compare
d7c6b25 to
437a44e
Compare
780dde0 to
0bc718d
Compare
437a44e to
17ef445
Compare
17ef445 to
3dfc0ca
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a Clippy warning about struct field naming by renaming fields to be more consistent and clear. The changes improve code readability by using more descriptive field names that better reflect their purpose.
- Renamed
workspace_dirtoroot_dirin theWorkspacestruct to better indicate it represents the workspace root directory - Renamed
package_manager_typetoclientin thePackageManagerstruct for cleaner API naming - Renamed
package_manager_typetoclient_overridein thePackageManagerBuilderstruct to clarify its purpose as an override option
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/vite_task/src/config/workspace.rs | Renamed struct field and updated all references from workspace_dir to root_dir |
| crates/vite_task/src/schedule.rs | Updated reference to use new root_dir field name |
| crates/vite_task/src/lib.rs | Updated reference to use new root_dir field name |
| crates/vite_task/src/config/mod.rs | Updated reference to use new root_dir field name |
| crates/vite_package_manager/src/package_manager.rs | Renamed struct fields from package_manager_type to client and package_manager_type to client_override in builder |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fengmk2
approved these changes
Oct 3, 2025
Member
Author
Merge activity
|
branchseer
pushed a commit
that referenced
this pull request
Mar 10, 2026
Includes: - chore: cleanup outdated docs and code (#211) - Hide "Did you mean:" when there are no fuzzy match suggestions (#212) https://claude.ai/code/session_01RSBPa1P1A94WvPMDa8YaQE
fengmk2
pushed a commit
that referenced
this pull request
Mar 10, 2026
Includes: - chore: cleanup outdated docs and code (#211) - Hide "Did you mean:" when there are no fuzzy match suggestions (#212) https://claude.ai/code/session_01RSBPa1P1A94WvPMDa8YaQE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.