Skip to content

style: fix clippy::struct_field_names#212

Merged
Brooooooklyn merged 1 commit intomainfrom
10-03-style_fix_clippy_struct_field_names
Oct 3, 2025
Merged

style: fix clippy::struct_field_names#212
Brooooooklyn merged 1 commit intomainfrom
10-03-style_fix_clippy_struct_field_names

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member Author

Brooooooklyn commented Oct 3, 2025

@Brooooooklyn Brooooooklyn force-pushed the 10-03-style_fix_clippy_needless-pass-by-ref-mut branch 2 times, most recently from e7a71c1 to 780dde0 Compare October 3, 2025 06:59
@Brooooooklyn Brooooooklyn changed the base branch from 10-03-style_fix_clippy_needless-pass-by-ref-mut to graphite-base/212 October 3, 2025 07:21
@Brooooooklyn Brooooooklyn force-pushed the 10-03-style_fix_clippy_struct_field_names branch from d7c6b25 to 437a44e Compare October 3, 2025 07:22
@graphite-app graphite-app Bot changed the base branch from graphite-base/212 to main October 3, 2025 07:22
@Brooooooklyn Brooooooklyn force-pushed the 10-03-style_fix_clippy_struct_field_names branch from 437a44e to 17ef445 Compare October 3, 2025 07:22
@Brooooooklyn Brooooooklyn force-pushed the 10-03-style_fix_clippy_struct_field_names branch from 17ef445 to 3dfc0ca Compare October 3, 2025 07:37
Copilot AI review requested due to automatic review settings October 3, 2025 07:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a Clippy warning about struct field naming by renaming fields to be more consistent and clear. The changes improve code readability by using more descriptive field names that better reflect their purpose.

  • Renamed workspace_dir to root_dir in the Workspace struct to better indicate it represents the workspace root directory
  • Renamed package_manager_type to client in the PackageManager struct for cleaner API naming
  • Renamed package_manager_type to client_override in the PackageManagerBuilder struct to clarify its purpose as an override option

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/vite_task/src/config/workspace.rs Renamed struct field and updated all references from workspace_dir to root_dir
crates/vite_task/src/schedule.rs Updated reference to use new root_dir field name
crates/vite_task/src/lib.rs Updated reference to use new root_dir field name
crates/vite_task/src/config/mod.rs Updated reference to use new root_dir field name
crates/vite_package_manager/src/package_manager.rs Renamed struct fields from package_manager_type to client and package_manager_type to client_override in builder

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Brooooooklyn Brooooooklyn merged commit 096aca2 into main Oct 3, 2025
9 checks passed
Copy link
Copy Markdown
Member Author

Merge activity

@Brooooooklyn Brooooooklyn deleted the 10-03-style_fix_clippy_struct_field_names branch October 3, 2025 12:20
branchseer pushed a commit that referenced this pull request Mar 10, 2026
Includes:
- chore: cleanup outdated docs and code (#211)
- Hide "Did you mean:" when there are no fuzzy match suggestions (#212)

https://claude.ai/code/session_01RSBPa1P1A94WvPMDa8YaQE
fengmk2 pushed a commit that referenced this pull request Mar 10, 2026
Includes:
- chore: cleanup outdated docs and code (#211)
- Hide "Did you mean:" when there are no fuzzy match suggestions (#212)

https://claude.ai/code/session_01RSBPa1P1A94WvPMDa8YaQE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants