Skip to content

feat(pm): add fingerprint ignores for install command#216

Merged
fengmk2 merged 1 commit intomainfrom
10-10-feat_pm_install_with_ignore_patterns
Oct 13, 2025
Merged

feat(pm): add fingerprint ignores for install command#216
fengmk2 merged 1 commit intomainfrom
10-10-feat_pm_install_with_ignore_patterns

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Oct 10, 2025

Install benchmark on outline

From 4.991s to 0.052s

Before

# first time
executed task finished, path_reads: 121036, path_writes: 107260, outputs: 7, exit_status: exit status: 0

vite i  10.38s user 72.38s system 484% cpu 17.081 total

# cache hit
vite i  0.43s user 68.01s system 1371% cpu 4.991 total

After

# first time
executed task finished, path_reads: 121036, path_writes: 107260, outputs: 7, exit_status: exit status: 0
PostRunFingerprint created, got 51 inputs, fingerprint_ignores: Some(["**/*", "!**/package.json", "!**/.npmrc", "!**/.yarnrc", "!**/.yarnrc.yml", "!**/yarn.config.cjs", "!**/yarn.lock", "!**/.yarn/**/*", "!**/.pnp.cjs", "**/node_modules/**/*", "!**/node_modules", "!**/node_modules/@*", "**/node_modules/**/node_modules/**"])

vite i  10.31s user 20.77s system 261% cpu 11.889 total

# cache hit
vite i  0.03s user 0.03s system 113% cpu 0.052 total

Copy link
Copy Markdown
Member Author

fengmk2 commented Oct 10, 2025

@fengmk2 fengmk2 force-pushed the 10-10-feat_pm_install_with_ignore_patterns branch from 734ab5e to 681de35 Compare October 10, 2025 05:38
@fengmk2 fengmk2 marked this pull request as ready for review October 10, 2025 05:40
@fengmk2 fengmk2 self-assigned this Oct 10, 2025
@fengmk2 fengmk2 force-pushed the 10-10-feat_pm_install_with_ignore_patterns branch from 681de35 to 482040c Compare October 10, 2025 05:47
@fengmk2 fengmk2 changed the title feat(pm): install with ignore patterns feat(pm): add fingerprint ignores for dependency tracking Oct 10, 2025
@fengmk2 fengmk2 changed the title feat(pm): add fingerprint ignores for dependency tracking feat(pm): add fingerprint ignores for install command Oct 10, 2025
Copy link
Copy Markdown
Member Author

fengmk2 commented Oct 13, 2025

Merge activity

  • Oct 13, 4:32 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 13, 4:34 AM UTC: Graphite couldn't merge this PR because it had merge conflicts.
  • Oct 13, 4:41 AM UTC: @fengmk2 merged this pull request with Graphite.

@fengmk2 fengmk2 changed the base branch from 10-09-feat_task_support_cache_fingerprint_ignore_patterns to graphite-base/216 October 13, 2025 04:32
@fengmk2 fengmk2 changed the base branch from graphite-base/216 to main October 13, 2025 04:32
Copilot AI review requested due to automatic review settings October 13, 2025 04:36
@fengmk2 fengmk2 force-pushed the 10-10-feat_pm_install_with_ignore_patterns branch from 482040c to 936b08e Compare October 13, 2025 04:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds fingerprint ignores for the install command to improve caching performance by reducing unnecessary file system monitoring. The implementation provides package manager-specific patterns to include only relevant files while ignoring most others during fingerprinting.

  • Added fingerprint ignores configuration to significantly reduce file system reads during install operations
  • Updated install command to use package manager-specific ignore patterns
  • Fixed pnpmfile.cjs detection to support both modern (.pnpmfile.cjs) and legacy (pnpmfile.cjs) formats

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
crates/vite_task/src/install.rs Modified install command to use fingerprint ignores instead of None
crates/vite_package_manager/src/package_manager.rs Added get_fingerprint_ignores method with package manager-specific patterns and updated pnpmfile detection

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread crates/vite_package_manager/src/package_manager.rs
@fengmk2 fengmk2 merged commit f090273 into main Oct 13, 2025
9 checks passed
@fengmk2 fengmk2 deleted the 10-10-feat_pm_install_with_ignore_patterns branch October 13, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants