feat(pm): add fingerprint ignores for install command#216
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
734ab5e to
681de35
Compare
681de35 to
482040c
Compare
branchseer
approved these changes
Oct 13, 2025
Member
Author
482040c to
936b08e
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds fingerprint ignores for the install command to improve caching performance by reducing unnecessary file system monitoring. The implementation provides package manager-specific patterns to include only relevant files while ignoring most others during fingerprinting.
- Added fingerprint ignores configuration to significantly reduce file system reads during install operations
- Updated install command to use package manager-specific ignore patterns
- Fixed pnpmfile.cjs detection to support both modern (.pnpmfile.cjs) and legacy (pnpmfile.cjs) formats
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/vite_task/src/install.rs | Modified install command to use fingerprint ignores instead of None |
| crates/vite_package_manager/src/package_manager.rs | Added get_fingerprint_ignores method with package manager-specific patterns and updated pnpmfile detection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Install benchmark on outline
From 4.991s to 0.052s
Before
After