Skip to content

chore(cli): restore to run snap-test parallel #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 1 commit into from
Oct 25, 2025
Merged

chore(cli): restore to run snap-test parallel #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/tools/src/snap-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,26 +36,19 @@ process.on('exit', () => fs.rmSync(tempTmpDir, { recursive: true, force: true })
const casesDir = path.resolve('snap-tests');

const filter = process.argv[2] ?? ''; // Optional filter to run specific test cases
const isCI = process.env.CI === 'true';

const tasks: Promise<void>[] = [];
for (const caseName of fs.readdirSync(casesDir)) {
if (caseName.startsWith('.')) continue; // Skip hidden files like .DS_Store
if (caseName.includes(filter)) {
if (isCI) {
// FIXME: parallel run will cause panicked: Access tokio runtime failed in spawn, maybe related to napi-3.3.0/src/tokio_runtime.rs:113:6
// see https://app.graphite.dev/github/pr/voidzero-dev/vite-plus/251/chore(cli)-restore-to-run-snap-test-parallel
await runTestCase(caseName);
} else {
// let snap-test run faster on local machine
tasks.push(runTestCase(caseName));
}
tasks.push(runTestCase(caseName));
}
}

if (tasks.length > 0) {
await Promise.all(tasks);
}

interface Steps {
ignoredPlatforms?: string[];
env: Record<string, string>;
Expand Down
Loading