chore: make impl_handler macro self-contained#268
Merged
branchseer merged 1 commit intomainfrom Oct 28, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the impl_handler macro to be self-contained by re-exporting Sysno from fspy_seccomp_unotify instead of requiring direct access to the syscalls crate.
Key Changes:
- Re-exported
Sysnotype fromfspy_seccomp_unotify::supervisor::handlermodule - Updated
impl_handlermacro to referenceSysnothrough$cratepath - Removed direct
syscallsdependency fromfspycrate
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/fspy_seccomp_unotify/src/supervisor/handler/mod.rs | Added Sysno re-export and updated macro paths to use $crate::supervisor::handler::Sysno |
| crates/fspy/Cargo.toml | Removed direct dependency on syscalls crate |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
approved these changes
Oct 28, 2025
branchseer
force-pushed
the
10-28-chore_make_impl_handler_macro_self-contained
branch
from
664f00c to
4653033
Compare
Member
Author
Merge activity
|
branchseer
deleted the
10-28-chore_make_impl_handler_macro_self-contained
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the direct dependency on
syscallscrate fromfspyand re-exportedSysnofrom thefspy_seccomp_unotifycrate.Why make this change?
This change improves the crate's dependency structure by removing a direct dependency on
syscallsfrom thefspycrate. Instead,fspynow uses theSysnotype that's re-exported fromfspy_seccomp_unotify, which already depends onsyscalls. This reduces dependency coupling and makes the API more self-contained.