chore: remove & check unused dependencies#269
Merged
branchseer merged 9 commits intomainfrom Oct 28, 2025
Merged
Conversation
branchseer
changed the title
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 28, 2025
branchseer
changed the title
branchseer
changed the base branch from
10-28-chore_make_impl_handler_macro_self-contained
to
graphite-base/269
fengmk2
approved these changes
Oct 28, 2025
Merge activity
|
# Conflicts: # Cargo.lock # crates/fspy/Cargo.toml # Conflicts: # crates/vite_install/Cargo.toml
# Conflicts: # Cargo.lock
branchseer
force-pushed
the
graphite-base/269
branch
from
664f00c to
48b72e9
Compare
branchseer
force-pushed
the
10-28-chore_remove_unused_dependencies
branch
from
bb1f7ad to
68e28b2
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused dependencies across multiple crates and adds cargo shear to the CI pipeline to prevent unused dependencies from being reintroduced. The changes ensure all declared dependencies are actually used in the codebase.
Key changes:
- Removed unused dependencies from 11 crate manifests
- Added
cargo shearto CI workflow to enforce dependency hygiene - Moved
vite_globfrom dev-dependencies to dependencies invite_install
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/vite_workspace/Cargo.toml | Removed unused test-log dev-dependency |
| crates/vite_task/Cargo.toml | Removed 7 unused dependencies including clap, crossterm, edit, and tracing-subscriber |
| crates/vite_install/Cargo.toml | Removed anyhow and tracing-subscriber; moved vite_glob from dev to main dependencies |
| crates/vite_error/Cargo.toml | Removed unused serde dependency |
| crates/fspy_shared/Cargo.toml | Removed platform-specific dependencies and memmap2 |
| crates/fspy_seccomp_unotify/Cargo.toml | Removed unused arrayvec and bytes dependencies |
| crates/fspy_preload_windows/Cargo.toml | Removed 7 unused dependencies including arrayvec, backtrace, and which |
| crates/fspy_preload_unix/Cargo.toml | Removed Linux and Unix-specific unused dependencies |
| crates/fspy_e2e/Cargo.toml | Removed unused futures-util dependency |
| crates/fspy/Cargo.toml | Removed multiple unused dependencies across different platform targets |
| Cargo.toml | Removed workspace-level dependency declarations and added cargo-shear metadata |
| .github/workflows/ci.yml | Added cargo shear tool installation and check to CI lint job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo shearnow passes