feat: add rolldown and rolldown-vite as sub packages#271
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5ab322a to
1f3635a
Compare
562f2d0 to
116df18
Compare
07a4d43 to
135be4b
Compare
6c0e4cd to
9bafab1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds rolldown and rolldown-vite as sub-packages to the monorepo, enabling the project to bundle these dependencies directly. Key changes include:
- Added tooling to sync and merge dependencies from upstream rolldown and rolldown-vite repositories
- Modified build process to bundle rolldown, rolldown-vite, and related tools (tsdown, vitepress, vitest) into the CLI package
- Updated workspace configuration to include rolldown sub-packages with pinned upstream versions
Reviewed Changes
Copilot reviewed 38 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Excludes rolldown directories from test coverage |
| vite-task.json | Defines build task dependencies for rolldown packages |
| pnpm-workspace.yaml | Adds rolldown workspaces and extensive catalog entries for merged dependencies |
| packages/tools/tsconfig.json | Enables JSON module resolution for upstream version tracking |
| packages/tools/src/sync-remote-deps.ts | Implements comprehensive tooling for syncing upstream repositories and merging package exports |
| packages/tools/src/merge-peer-deps.ts | New utility for merging peer dependencies from multiple packages |
| packages/tools/src/index.ts | Registers new merge-peer-deps subcommand |
| packages/tools/.upstream-versions.json | Tracks pinned commit hashes for upstream repositories |
| packages/global/src/index.ts | Removes ts-ignore comment |
| packages/global/rolldown.config.ts | Simplifies external dependencies configuration |
| packages/global/package.json | Changes rolldown dependencies to workspace references |
| packages/cli/vite-rolldown.config.ts | Symlink to rolldown-vite configuration |
| packages/cli/tsconfig.json | Switches to ESNext module system and adds experimental decorators |
| packages/cli/src/*.ts | Updates resolver functions to use bundled binaries instead of node resolution |
| packages/cli/snap-tests/* | Updates test expectations for new output formats |
| packages/cli/rollupLicensePlugin.ts | Symlink to rolldown-vite plugin |
| packages/cli/package.json | Extensive updates to exports, dependencies, and peer dependencies |
| packages/cli/copy-addon-plugin.ts | Symlink to rolldown plugin |
| packages/cli/build.ts | Complete rewrite to orchestrate building and bundling all sub-packages |
| packages/cli/build-support/rewrite-imports.ts | New plugin for rewriting import paths during bundling |
| packages/cli/binding/src/*.rs | Updates command execution to use bundled binaries with node wrapper |
| package.json | Updates package manager version and test command |
| .gitignore | Excludes rolldown directories |
| .github/workflows/* | Updates CI/CD to clone and build upstream repositories |
| .github/actions/* | New actions for cloning and building upstream repositories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f39676d to
a43e4bb
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 41 out of 43 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
CI in main only runs vite-task smoke test on Windows. In https://app.graphite.com/github/pr/voidzero-dev/vite-plus/298/test-enable-command-helper-test-in-Windows I tried to turn on the command-helper test. Looks like there are still some issues on Windows: https://github.com/voidzero-dev/vite-plus/runs/55068835966 |
Merge activity
|

No description provided.