Skip to content

feat: add rolldown and rolldown-vite as sub packages#271

Merged
Brooooooklyn merged 3 commits intomainfrom
10-28-import-rolldown-and-vite
Nov 12, 2025
Merged

feat: add rolldown and rolldown-vite as sub packages#271
Brooooooklyn merged 3 commits intomainfrom
10-28-import-rolldown-and-vite

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

@Brooooooklyn Brooooooklyn commented Oct 28, 2025

No description provided.

Copy link
Copy Markdown
Member Author

Brooooooklyn commented Oct 28, 2025

@Brooooooklyn Brooooooklyn force-pushed the 10-28-import-rolldown-and-vite branch 20 times, most recently from 5ab322a to 1f3635a Compare November 1, 2025 08:25
Comment thread packages/cli/build.ts Outdated
@Brooooooklyn Brooooooklyn force-pushed the 10-28-import-rolldown-and-vite branch 2 times, most recently from 562f2d0 to 116df18 Compare November 3, 2025 14:58
Comment thread packages/cli/src/resolve-vite.ts Outdated
@Brooooooklyn Brooooooklyn force-pushed the 10-28-import-rolldown-and-vite branch 4 times, most recently from 07a4d43 to 135be4b Compare November 5, 2025 09:43
@Brooooooklyn Brooooooklyn force-pushed the 10-28-import-rolldown-and-vite branch 6 times, most recently from 6c0e4cd to 9bafab1 Compare November 11, 2025 07:03
@Brooooooklyn Brooooooklyn marked this pull request as ready for review November 11, 2025 07:30
Copilot AI review requested due to automatic review settings November 11, 2025 07:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds rolldown and rolldown-vite as sub-packages to the monorepo, enabling the project to bundle these dependencies directly. Key changes include:

  • Added tooling to sync and merge dependencies from upstream rolldown and rolldown-vite repositories
  • Modified build process to bundle rolldown, rolldown-vite, and related tools (tsdown, vitepress, vitest) into the CLI package
  • Updated workspace configuration to include rolldown sub-packages with pinned upstream versions

Reviewed Changes

Copilot reviewed 38 out of 40 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vite.config.ts Excludes rolldown directories from test coverage
vite-task.json Defines build task dependencies for rolldown packages
pnpm-workspace.yaml Adds rolldown workspaces and extensive catalog entries for merged dependencies
packages/tools/tsconfig.json Enables JSON module resolution for upstream version tracking
packages/tools/src/sync-remote-deps.ts Implements comprehensive tooling for syncing upstream repositories and merging package exports
packages/tools/src/merge-peer-deps.ts New utility for merging peer dependencies from multiple packages
packages/tools/src/index.ts Registers new merge-peer-deps subcommand
packages/tools/.upstream-versions.json Tracks pinned commit hashes for upstream repositories
packages/global/src/index.ts Removes ts-ignore comment
packages/global/rolldown.config.ts Simplifies external dependencies configuration
packages/global/package.json Changes rolldown dependencies to workspace references
packages/cli/vite-rolldown.config.ts Symlink to rolldown-vite configuration
packages/cli/tsconfig.json Switches to ESNext module system and adds experimental decorators
packages/cli/src/*.ts Updates resolver functions to use bundled binaries instead of node resolution
packages/cli/snap-tests/* Updates test expectations for new output formats
packages/cli/rollupLicensePlugin.ts Symlink to rolldown-vite plugin
packages/cli/package.json Extensive updates to exports, dependencies, and peer dependencies
packages/cli/copy-addon-plugin.ts Symlink to rolldown plugin
packages/cli/build.ts Complete rewrite to orchestrate building and bundling all sub-packages
packages/cli/build-support/rewrite-imports.ts New plugin for rewriting import paths during bundling
packages/cli/binding/src/*.rs Updates command execution to use bundled binaries with node wrapper
package.json Updates package manager version and test command
.gitignore Excludes rolldown directories
.github/workflows/* Updates CI/CD to clone and build upstream repositories
.github/actions/* New actions for cloning and building upstream repositories

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/build.ts
Comment thread .github/workflows/release.yml
Comment thread package.json
Comment thread packages/cli/package.json
Comment thread packages/cli/package.json
Comment thread .gitignore Outdated
Comment thread .github/actions/clone/action.yml
Copilot AI review requested due to automatic review settings November 11, 2025 11:35
@Brooooooklyn Brooooooklyn force-pushed the 10-28-import-rolldown-and-vite branch from f39676d to a43e4bb Compare November 11, 2025 11:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 41 out of 43 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cli/binding/src/commands/vite.rs
Comment thread packages/cli/binding/src/commands/test.rs
Comment thread packages/cli/binding/src/commands/lint.rs
Comment thread packages/cli/binding/src/commands/lib_cmd.rs
Comment thread packages/cli/binding/src/commands/fmt.rs
Comment thread packages/cli/binding/src/commands/doc.rs
Copy link
Copy Markdown
Member

branchseer commented Nov 11, 2025

CI in main only runs vite-task smoke test on Windows.

In https://app.graphite.com/github/pr/voidzero-dev/vite-plus/298/test-enable-command-helper-test-in-Windows I tried to turn on the command-helper test. Looks like there are still some issues on Windows: https://github.com/voidzero-dev/vite-plus/runs/55068835966

Copy link
Copy Markdown
Member Author

Brooooooklyn commented Nov 12, 2025

Merge activity

  • Nov 12, 2:04 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 12, 2:04 AM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn merged commit ec58edc into main Nov 12, 2025
16 of 17 checks passed
@Brooooooklyn Brooooooklyn deleted the 10-28-import-rolldown-and-vite branch November 12, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants