chore: update binding files and minor tweaks#279
Merged
Brooooooklyn merged 1 commit intomainfrom Oct 30, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the @napi-rs/cli package from version 3.1.5 to 3.4.1 and adds necessary configuration changes to support this upgrade. The changes include updating dependency versions in the pnpm workspace catalog, excluding @napi-rs/* packages from minimum release age checks, implementing catalog key sorting, and updating the native binding loader with enhanced platform support.
- Updated
@napi-rs/clifrom 3.1.5 to 3.4.1 with transitive dependency updates - Added
@napi-rs/*tominimumReleaseAgeExcludefor faster dependency updates - Enhanced native binding loader with Windows GNU and Linux loong64 architecture support
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updated @napi-rs/cli version to 3.4.1 and added @napi-rs/* to minimum release age exclusions |
| pnpm-lock.yaml | Updated lockfile with new versions for @napi-rs/cli and all related inquirer/napi-rs packages |
| packages/tools/src/sync-remote-deps.ts | Added alphabetical sorting for catalog keys |
| packages/cli/binding/index.js | Enhanced native binding loader with Windows GNU support, loong64 architecture, and improved error handling |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
reviewed
Oct 30, 2025
fengmk2
approved these changes
Oct 30, 2025
Member
Author
Merge activity
|
Brooooooklyn
deleted the
10-30-chore_update_binding_files_and_minor_tweaks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.