Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
branchseer
force-pushed
the
11-05-ci_enable_e2e_test_on_windows_ci
branch
from
040642d to
369c7d5
Compare
branchseer
force-pushed
the
11-05-ci_enable_e2e_test_on_windows_ci
branch
3 times, most recently
from
4d841fb to
bb2f497
Compare
branchseer
changed the base branch from
11-04-ci_fix_windows_ci_issues
to
graphite-base/293
branchseer
force-pushed
the
11-05-ci_enable_e2e_test_on_windows_ci
branch
from
bb2f497 to
6a0ae96
Compare
branchseer
force-pushed
the
graphite-base/293
branch
from
70d6331 to
6f6ba6f
Compare
branchseer
force-pushed
the
11-05-ci_enable_e2e_test_on_windows_ci
branch
from
6a0ae96 to
a51de37
Compare
Merged
Add "ignoredPlatforms": ["win32"] to snap tests that use builtin vite commands (not `vite run`). These tests use commands like `vite install`, `vite lint`, `vite build`, `vite test`, `vite lib`, `vite fmt`, `vite dev`, `vite cache clean`, and `vite doc` which need to be skipped on Windows CI. Modified 18 test cases to exclude Windows platform. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add "ignoredPlatforms": ["win32"] to snap tests that have echo scripts in their package.json. The echo command behaves differently on Windows (different syntax and behavior), causing these tests to fail or produce incorrect results. Modified 7 test cases: - associate-existing-cache - cache-miss-command-change - exit-code - individual-cache-for-adt-args - plain-terminal-ui - task-no-trailing-newline - test-nested-tasks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
# Conflicts: # packages/tools/src/snap-test.ts
branchseer
force-pushed
the
11-05-ci_enable_e2e_test_on_windows_ci
branch
from
a51de37 to
2d4844c
Compare
branchseer
force-pushed
the
11-05-ci_enable_e2e_test_on_windows_ci
branch
from
71640c6 to
a9ce16d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Windows in snap tests by implementing timeouts for test execution and marking most existing tests to be skipped on Windows. The main changes include adding a 30-second timeout mechanism for test commands, ensuring the process exits properly after tests complete, and marking tests as Windows-incompatible where needed.
Key changes:
- Implemented a 30-second timeout for test command execution with proper handling
- Added explicit
process.exit(0)after test completion to handle pending timed-out steps - Updated Rust dependencies to use a feature branch of vite-task for Windows compatibility
- Marked 70+ existing snap tests to be skipped on Windows platform
- Added one new test case (vite-task-smoke) that runs on all platforms
- Updated CI workflow to include Windows in test matrix
Reviewed Changes
Copilot reviewed 87 out of 88 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/tools/src/snap-test.ts | Added timeout mechanism and process exit handling for test runner |
| packages/cli/snap-tests/vite-task-smoke/* | New test case demonstrating task runner caching functionality |
| packages//snap-tests//steps.json | Added ignoredPlatforms configuration to skip tests on win32 |
| Cargo.toml | Updated vite_task dependencies to feature branch for Windows support |
| Cargo.lock | Updated dependency checksums and versions |
| .github/workflows/ci.yml | Added Windows to test matrix with separate execution path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 95 out of 96 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
reviewed
Nov 8, 2025
fengmk2
approved these changes
Nov 8, 2025
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.