Skip to content

fix(cli): Windows path issues#300

Merged
Brooooooklyn merged 2 commits intomainfrom
11-12-fix_cli_windows_path_issues
Nov 12, 2025
Merged

fix(cli): Windows path issues#300
Brooooooklyn merged 2 commits intomainfrom
11-12-fix_cli_windows_path_issues

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings November 12, 2025 07:22
Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Windows path compatibility issues in the CLI by ensuring proper path separators are used and the correct Node.js executable is invoked on Windows.

Key Changes:

  • Updated path comparison in TypeScript build script to use platform-agnostic path joining
  • Added Windows-specific handling to use node.exe instead of node across all command modules

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/cli/build.ts Fixed path comparison to use join() for cross-platform path separator handling
packages/cli/binding/src/commands/vite.rs Added conditional logic to use node.exe on Windows
packages/cli/binding/src/commands/test.rs Added conditional logic to use node.exe on Windows
packages/cli/binding/src/commands/lint.rs Added conditional logic to use node.exe on Windows
packages/cli/binding/src/commands/lib_cmd.rs Added conditional logic to use node.exe on Windows
packages/cli/binding/src/commands/fmt.rs Added conditional logic to use node.exe on Windows
packages/cli/binding/src/commands/doc.rs Added conditional logic to use node.exe on Windows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cli/binding/src/commands/doc.rs Outdated
Comment thread packages/cli/binding/src/commands/doc.rs Outdated
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Nov 12, 2025

Merge activity

  • Nov 12, 9:42 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 12, 9:43 AM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn merged commit 82b8838 into main Nov 12, 2025
20 of 21 checks passed
@Brooooooklyn Brooooooklyn deleted the 11-12-fix_cli_windows_path_issues branch November 12, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants