fix(tools): merge exports field correctly#303
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the merging of exports fields in the tools package by refactoring how Vite and Vitest exports are transformed and merged into the CLI package.json. The key changes include:
- Converting
syncRemoteto an async function to support dynamic imports - Simplifying Vite export transformation to keep export keys unchanged (only transforming values)
- Adding comprehensive Vitest export transformation and merging
- Implementing export sorting for consistent output
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/tools/src/sync-remote-deps.ts |
Refactored to use dynamic imports for dependencies, simplified Vite export transformation logic, added Vitest export transformation, and added export sorting |
packages/tools/src/index.ts |
Updated to await the now-async syncRemote function |
packages/cli/package.json |
Re-ordered and updated exports after running the updated merge logic |
pnpm-workspace.yaml |
Added Vite ^7.0.0 to catalog and updated Vite override to point to rolldown-vite packages |
justfile |
Added pnpm tool sync-remote to the init command to ensure remote dependencies are synced during initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Brooooooklyn
force-pushed
the
11-13-fix_tools_merge_exports_field_correctly
branch
from
322ff8f to
6b3d8dd
Compare
Brooooooklyn
force-pushed
the
11-13-fix_tools_merge_exports_field_correctly
branch
from
6b3d8dd to
6b2f062
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Brooooooklyn
force-pushed
the
11-13-fix_tools_merge_exports_field_correctly
branch
from
6b2f062 to
d6cc24a
Compare
Brooooooklyn
force-pushed
the
11-13-fix_tools_merge_exports_field_correctly
branch
from
d6cc24a to
00a6394
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Brooooooklyn
force-pushed
the
11-13-fix_tools_merge_exports_field_correctly
branch
from
00a6394 to
9fe6162
Compare
Brooooooklyn
force-pushed
the
11-13-fix_tools_merge_exports_field_correctly
branch
from
9fe6162 to
d66e1f8
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Brooooooklyn
force-pushed
the
11-13-fix_tools_merge_exports_field_correctly
branch
from
d66e1f8 to
749e844
Compare
Merge activity
|
Brooooooklyn
deleted the
11-13-fix_tools_merge_exports_field_correctly
branch
No description provided.