Skip to content

refactor(global): global cli completely independent#338

Merged
fengmk2 merged 1 commit intomainfrom
12-10-refactor_global_global_cli_completely_independent
Dec 17, 2025
Merged

refactor(global): global cli completely independent#338
fengmk2 merged 1 commit intomainfrom
12-10-refactor_global_global_cli_completely_independent

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Dec 10, 2025

No description provided.

Comment thread packages/global/package.json Outdated
@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch 9 times, most recently from dc5ffa9 to 712e3c4 Compare December 11, 2025 09:00
@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch from 712e3c4 to c658c82 Compare December 11, 2025 09:31
@fengmk2 fengmk2 self-assigned this Dec 11, 2025
@fengmk2 fengmk2 marked this pull request as ready for review December 11, 2025 09:35
@fengmk2 fengmk2 requested review from Brooooooklyn, branchseer and Copilot and removed request for Copilot December 11, 2025 09:35
Copilot AI review requested due to automatic review settings December 11, 2025 09:45
@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch from c658c82 to d917590 Compare December 11, 2025 09:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the global CLI to be completely independent from the local CLI package. The main changes separate global commands (gen, migration, package manager utilities) from local commands (dev, build, test, lint, fmt, etc.) by introducing a new Rust binding layer for the global CLI and delegating local commands to the @voidzero-dev/vite-plus package when installed.

Key Changes:

  • Introduced new Rust binding layer for global CLI with package manager detection, migration utilities, and command execution
  • Split command routing to delegate local CLI commands (dev, build, test, lint, fmt, lib, doc, run) to the installed local CLI package
  • Moved package manager selection logic from local CLI to shared vite_install crate
  • Updated import paths from .ts to .js extensions throughout the global package

Reviewed changes

Copilot reviewed 100 out of 116 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/global/binding/* New Rust binding layer providing package manager detection, migration, and command execution capabilities
packages/global/src/index.ts Updated routing logic to delegate local CLI commands vs global commands
packages/global/src/local/bin.ts New module to auto-install and delegate to local CLI
packages/global/src/global/bin.ts New entry point for global Rust commands
packages/global/src/utils/* Updated imports and added package metadata detection utilities
packages/cli/binding/src/* Removed duplicate code migrated to global or shared crates
crates/vite_install/* Added package manager selection prompts moved from CLI binding
vite.config.ts Updated test exclusion pattern to be more generic
package.json, justfile, .github/* Build and CI configuration updates
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/global/src/local/bin.ts Outdated
@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch from d917590 to 9584148 Compare December 11, 2025 10:11
Copilot AI review requested due to automatic review settings December 11, 2025 10:48
@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch from 9584148 to e3fe2fa Compare December 11, 2025 10:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 100 out of 116 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/global/src/index.ts
Comment thread packages/global/src/local/bin.ts Outdated
@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch from e3fe2fa to 67c4bca Compare December 12, 2025 03:58
Copilot AI review requested due to automatic review settings December 12, 2025 09:00
@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch from 67c4bca to 4ae86d3 Compare December 12, 2025 09:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 101 out of 117 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/global/snap-tests/cli-helper-message/snap.txt
@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch from 4ae86d3 to b4e29db Compare December 15, 2025 12:37
Copilot AI review requested due to automatic review settings December 16, 2025 06:15
@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch from b4e29db to 5655019 Compare December 16, 2025 06:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 101 out of 117 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fengmk2 fengmk2 force-pushed the 12-10-refactor_global_global_cli_completely_independent branch from 5655019 to 3a67a92 Compare December 17, 2025 06:01
Copy link
Copy Markdown
Member Author

fengmk2 commented Dec 17, 2025

Merge activity

  • Dec 17, 6:02 AM UTC: Graphite rebased this pull request as part of a merge.
  • Dec 17, 6:15 AM UTC: @fengmk2 merged this pull request with Graphite.

@fengmk2 fengmk2 merged commit fe27503 into main Dec 17, 2025
12 checks passed
@fengmk2 fengmk2 deleted the 12-10-refactor_global_global_cli_completely_independent branch December 17, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants