Skip to content

fix: add docs/pnpm-workspace.yaml to isolate docs from root workspace#747

Merged
fengmk2 merged 1 commit intomainfrom
fix-docs-deploy-v3
Mar 10, 2026
Merged

fix: add docs/pnpm-workspace.yaml to isolate docs from root workspace#747
fengmk2 merged 1 commit intomainfrom
fix-docs-deploy-v3

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Mar 10, 2026

Add a pnpm-workspace.yaml in docs/ so pnpm won't traverse up to the
root workspace (which fails on missing rolldown-vite patches). This
allows using base=docs/ directly in netlify.toml, so Netlify watches
docs/ for changes and builds trigger correctly.

Add a pnpm-workspace.yaml in docs/ so pnpm won't traverse up to the
root workspace (which fails on missing rolldown-vite patches). This
allows using base=docs/ directly in netlify.toml, so Netlify watches
docs/ for changes and builds trigger correctly.
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 10, 2026

Deploy Preview for viteplus-staging ready!

Name Link
🔨 Latest commit 70b866c
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-staging/deploys/69af74df47ae2a0008a43fa2
😎 Deploy Preview https://deploy-preview-747--viteplus-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fengmk2 fengmk2 self-assigned this Mar 10, 2026
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 10, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 marked this pull request as ready for review March 10, 2026 01:34
@fengmk2 fengmk2 requested a review from cpojer March 10, 2026 01:34
Copy link
Copy Markdown
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this will also work still as part of a workspace. I have only used this in repos where the sub-package was not part of the workspace at all. Let's try it though, I guess you can validate via preview deploys?

Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 10, 2026

I don't know if this will also work still as part of a workspace. I have only used this in repos where the sub-package was not part of the workspace at all. Let's try it though, I guess you can validate via preview deploys?

​yes, preview deploy success. 😀

@fengmk2 fengmk2 merged commit 8f053ef into main Mar 10, 2026
22 checks passed
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 10, 2026

Merge activity

@fengmk2 fengmk2 deleted the fix-docs-deploy-v3 branch March 10, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants