fix: resolve vp run crash when task script contains global CLI subcommands#766
Merged
fix: resolve vp run crash when task script contains global CLI subcommands#766
vp run crash when task script contains global CLI subcommands#766Conversation
✅ Deploy Preview for viteplus-staging canceled.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
fix-vp-run-prepare
branch
from
dc02933 to
e7f3e05
Compare
branchseer
reviewed
Mar 10, 2026
`vp run` crashed when a task script contained global-only commands like `vp config` because CLIArgs parsing failed on unrecognized subcommands. Now InvalidSubcommand errors return HandledCommand::Verbatim, letting the global CLI binary handle them as regular subprocesses.
…cripts Per review feedback, use Synthesized with UserCacheConfig::disabled() instead of Verbatim for commands that should not be cached: global subcommands (vp config, etc.), vp exec, and vp check.
fengmk2
force-pushed
the
fix-vp-run-prepare
branch
from
e7f3e05 to
df46871
Compare
fengmk2
commented
Mar 10, 2026
branchseer
approved these changes
Mar 10, 2026
fengmk2
changed the title
vp run crash when task script contains global CLI subcommands
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp runcrashed when a task script contained global-only commands likevp configbecauseCLIArgs::try_parse_fromfailed on unrecognized subcommands withErrorKind::InvalidSubcommandInvalidSubcommanderrors returnHandledCommand::SynthesizedwithUserCacheConfig::disabled(), letting the global CLI binary handle them as regular subprocesses without cachingvp execandvp checkin task scripts, since they run arbitrary/composite commands with side effectsTest plan
global_subcommands_produce_invalid_subcommand_errorconfirmingconfig,create,env,migrateproduceInvalidSubcommandcommand-run-with-vp-configverifyingvp run foowith"foo": "vp config"no longer crashes