fix: show error output when vp check --fix fmt fails#798
Merged
Conversation
✅ Deploy Preview for viteplus-staging canceled.
|
fengmk2
force-pushed
the
fix-check-fix-missing-stderr
branch
from
65ca9b6 to
acdf9e9
Compare
branchseer
approved these changes
Mar 12, 2026
fengmk2
force-pushed
the
fix-check-fix-missing-stderr
branch
from
acdf9e9 to
3d4351e
Compare
When fmt failed during `vp check --fix`, the error output was silently swallowed because display logic was gated behind `if !fix`. Now the error is shown via a new `print_error_block` helper that consolidates the repeated error display pattern across all three fmt error paths.
fengmk2
force-pushed
the
fix-check-fix-missing-stderr
branch
from
3d4351e to
ca867a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fmt failed during
vp check --fix, the error output was silentlyswallowed because display logic was gated behind
if !fix. Now theerror is shown via a new
print_error_blockhelper that consolidatesthe repeated error display pattern across all three fmt error paths.