fix(test): preserve vitest/browser bare specifier in browser-context files#811
Merged
fix(test): preserve vitest/browser bare specifier in browser-context files#811
Conversation
…files The build process was rewriting `"vitest/browser"` to a relative `"./index.js"` path inside `@vitest/browser/` chunk files. This caused browser-side code to import the Node.js server file (~9000 lines) instead of resolving through Vite's virtual module plugin, which broke `page.extend()` for playwright locators (getByText, getByRole, etc.). Replace the fragile regex-based workaround with `specifierMap.delete()` to preserve the bare specifier for Vite's plugin resolution.
✅ Deploy Preview for viteplus-staging canceled.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Brooooooklyn
approved these changes
Mar 13, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build process was rewriting
"vitest/browser"to a relative"./index.js"path inside@vitest/browser/chunk files. This causedbrowser-side code to import the Node.js server file (~9000 lines) instead
of resolving through Vite's virtual module plugin, which broke
page.extend()for playwright locators (getByText, getByRole, etc.).Replace the fragile regex-based workaround with
specifierMap.delete()to preserve the bare specifier for Vite's plugin resolution.