Skip to content

fix(test): preserve vitest/browser bare specifier in browser-context files #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 1 commit into from
Mar 13, 2026
Merged

fix(test): preserve vitest/browser bare specifier in browser-context files #811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 10 additions & 32 deletions packages/test/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,6 +938,16 @@ async function rewriteVitestImports(leafDepToVendorPath: Map<string, string>) {
specifierMap.set(specifier, vendorPath);
}

// For files inside @vitest/browser/, preserve 'vitest/browser' as a bare specifier.
// These files run in browser context where the vitest:vendor-aliases plugin
// resolves 'vitest/browser' to the virtual module '\0vitest/browser',
// which provides browser-safe context API (page, server, userEvent, utils).
// Without this, 'vitest/browser' gets rewritten to './index.js' which resolves
// to the Node.js server file (~9000 lines of node:fs, ws, etc.)
if (file.includes('@vitest/browser') || file.includes('@vitest\\browser')) {
specifierMap.delete('vitest/browser');
}

// Rewrite using AST
const rewritten = rewriteImportsWithAst(content, file, false, specifierMap);

Expand All @@ -947,38 +957,6 @@ async function rewriteVitestImports(leafDepToVendorPath: Map<string, string>) {
.replaceAll(/import\(['"]vite['"]\)/g, `import('${CORE_PACKAGE_NAME}')`)
.replaceAll(`'vite/module-runner'`, `'${CORE_PACKAGE_NAME}/module-runner'`);

// Special handling for @vitest/browser files that import from ./index.js (Node.js-only)
// Replace: import{server,page,utils}from'./index.js' with browser-safe stubs
if (file.includes('@vitest/browser') || file.includes('@vitest\\browser')) {
// Replace server import with browser-safe stub
const serverStub = `const server = {
get browser() { return window.__vitest_browser_runner__?.config?.browser?.name; },
get config() { return window.__vitest_browser_runner__?.config || {}; },
get commands() { return window.__vitest_browser_runner__?.commands || {}; },
get provider() { return window.__vitest_browser_runner__?.provider; },
}`;
// Handle combined import: import{server,page,utils}from'./index.js'
finalContent = finalContent.replace(
/import\s*\{\s*server\s*,\s*page\s*,\s*utils\s*\}\s*from\s*['"]\.\/index\.js['"];?/g,
`${serverStub};const page = window.__vitest_browser_runner__?.page || {};const utils = window.__vitest_browser_runner__?.utils || {};`,
);
// Handle individual server import: import{server}from'./index.js'
finalContent = finalContent.replace(
/import\s*\{\s*server\s*\}\s*from\s*['"]\.\/index\.js['"];?/g,
serverStub + ';',
);
// Remove side-effect imports from ./index.js (Node.js-only)
finalContent = finalContent.replace(/import\s*['"]\.\/index\.js['"];?/g, '');

// Handle tester chunk imports from ../../index.js (browser needs virtual module interception)
// The tester chunk is in client/__vitest_browser__/ and imports from ../../index.js
// Change to 'vitest/browser' so the virtual module plugin can intercept at runtime
finalContent = finalContent.replace(
/import\s*\{\s*userEvent\s*,\s*page\s*,\s*server\s*\}\s*from\s*['"]\.\.\/\.\.\/index\.js['"];?/g,
"import { userEvent, page, server } from 'vitest/browser';",
);
}

// Special handling for @vitest/mocker entry files that have redundant side-effect imports
// The original files have: import 'magic-string'; export {...} from './chunk-automock.js'; import 'estree-walker';
// This is problematic because:
Expand Down
Loading