Skip to content

docs(fix): dark header flash#816

Closed
mdong1909 wants to merge 3 commits intomainfrom
fuoc-header
Closed

docs(fix): dark header flash#816
mdong1909 wants to merge 3 commits intomainfrom
fuoc-header

Conversation

@mdong1909
Copy link
Copy Markdown
Contributor

@mdong1909 mdong1909 commented Mar 13, 2026

Fixes:

Recording.2026-03-13.155344.2.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 13, 2026

Deploy Preview for viteplus-preview ready!

Name Link
🔨 Latest commit 10235b4
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69b3c37c39d491000845a428
😎 Deploy Preview https://deploy-preview-816--viteplus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 13, 2026

Deploy Preview for viteplus-staging ready!

Name Link
🔨 Latest commit 10235b4
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-staging/deploys/69b3c37bb69b120008b30657
😎 Deploy Preview https://deploy-preview-816--viteplus-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mdong1909 mdong1909 closed this Mar 13, 2026
@mdong1909 mdong1909 deleted the fuoc-header branch March 13, 2026 07:59
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10235b4ca5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/index.md
- - script
- id: home-theme-init
- |
document.documentElement.setAttribute('data-theme', 'light');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove forced root theme after home-page init

The injected home-page script permanently sets document.documentElement[data-theme='light'], but this commit also removed the route-change cleanup that previously called root.removeAttribute('data-theme') when leaving layout: home. In SPA navigation (load / first, then open any docs page), the root stays forced to light, so dark-mode CSS like :root.dark:not([data-theme]) in docs/.vitepress/theme/styles.css no longer applies and non-home pages render with the wrong theme variables.

Useful? React with 👍 / 👎.

@mdong1909 mdong1909 restored the fuoc-header branch March 13, 2026 08:01
@mdong1909 mdong1909 reopened this Mar 13, 2026
@mdong1909 mdong1909 marked this pull request as draft March 13, 2026 08:01
@mdong1909
Copy link
Copy Markdown
Contributor Author

this is a fix in the oss header

@mdong1909 mdong1909 closed this Mar 13, 2026
@mdong1909 mdong1909 deleted the fuoc-header branch March 13, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant