Skip to content

docs(fix): dark header flash #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdong1909 wants to merge 3 commits into from
Closed

docs(fix): dark header flash #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9cfd27
docs(fix): mobile menu dark mode in home
mdong1909 Mar 13, 2026
d8ea16f
Merge branch 'main' of https://github.com/voidzero-dev/vite-plus into…
mdong1909 Mar 13, 2026
10235b4
docs(fix): FOUC for dark header
mdong1909 Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions docs/.vitepress/theme/Layout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,12 @@ const setupHomeHeaderObserver = (header: HTMLElement | null, isHome: boolean) =>
});
};

const syncHomeThemeOverride = async () => {
const syncHomeHeaderState = async () => {
if (typeof document === 'undefined') {
return;
}

const isHome = frontmatter.value?.layout === 'home';
const root = document.documentElement;

if (isHome) {
root.setAttribute('data-theme', 'light');
} else {
root.removeAttribute('data-theme');
}

await nextTick();

Expand All @@ -68,19 +61,13 @@ const syncHomeThemeOverride = async () => {
return;
}

if (isHome) {
header.setAttribute('data-theme', 'light');
} else {
header.removeAttribute('data-theme');
}

syncHeaderMobileMenuTheme(header, isHome);
};

watch(
[() => frontmatter.value?.layout, () => isDark.value],
[() => frontmatter.value?.layout, () => frontmatter.value?.theme, () => isDark.value],
() => {
void syncHomeThemeOverride();
void syncHomeHeaderState();
},
{ immediate: true },
);
Expand All @@ -92,8 +79,12 @@ onUnmounted(() => {
</script>

<template>
<div v-if="frontmatter.layout === 'home'" class="marketing-layout">
<OSSHeader class="home-header" />
<div
v-if="frontmatter.layout === 'home'"
class="marketing-layout"
:data-theme="frontmatter.theme"
>
<OSSHeader class="home-header" :data-theme="frontmatter.theme" />
<Home />
<Footer />
</div>
Expand Down
5 changes: 5 additions & 0 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ home: true
layout: home
theme: light
titleTemplate: The Unified Toolchain for the Web
head:
- - script
- id: home-theme-init
- |
document.documentElement.setAttribute('data-theme', 'light');
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove forced root theme after home-page init

The injected home-page script permanently sets document.documentElement[data-theme='light'], but this commit also removed the route-change cleanup that previously called root.removeAttribute('data-theme') when leaving layout: home. In SPA navigation (load / first, then open any docs page), the root stays forced to light, so dark-mode CSS like :root.dark:not([data-theme]) in docs/.vitepress/theme/styles.css no longer applies and non-home pages render with the wrong theme variables.

Useful? React with 👍 / 👎.

---

<script setup>
Expand Down
Loading