Skip to content

fix: failed to check inside github action#914

Merged
fengmk2 merged 2 commits intovoidzero-dev:mainfrom
hyoban:3-13-check-in-ci
Mar 16, 2026
Merged

fix: failed to check inside github action#914
fengmk2 merged 2 commits intovoidzero-dev:mainfrom
hyoban:3-13-check-in-ci

Conversation

@hyoban
Copy link
Copy Markdown
Contributor

@hyoban hyoban commented Mar 15, 2026

Fixes voidzero-dev/setup-vp#7

I'm unsure whether we can produce good terminal output while retaining the GitHub reporter. If my fix is off course, please feel free to close this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 15, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 942b313
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69b75b4c2dcef40008631551

@fengmk2 fengmk2 requested review from Boshen and camc314 March 16, 2026 01:01
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented Mar 16, 2026

This fix looks feasible, but it loses the advantage of oxlint's special customized report output on GitHub Actions.
We need to see if there's any way to make oxlint's customized reports work together with the vp check command

@fengmk2 fengmk2 requested review from Copilot and fengmk2 March 16, 2026 01:21
@fengmk2 fengmk2 self-assigned this Mar 16, 2026
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented Mar 16, 2026

@Boshen I will first merge this fix to address the current issue where the vp check command is unavailable. Then I'll submit an issue to follow up on a better solution.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes vp check behaving incorrectly under GitHub Actions by ensuring oxlint emits the human-readable summary that vp check parses, and adds a snapshot test covering the GitHub Actions environment.

Changes:

  • Force oxlint to use the default formatter during vp check linting to keep parseable/stable summary output even when GITHUB_ACTIONS=true.
  • Add a new snap-test case that runs vp check with GITHUB_ACTIONS=true to prevent regressions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/cli/binding/src/cli.rs Forces vp check’s lint step to pass --format=default to oxlint so summary parsing works in GitHub Actions.
packages/cli/snap-tests/check-pass-typecheck-github-actions/vite.config.ts New snap-test config enabling type-aware/type-check linting.
packages/cli/snap-tests/check-pass-typecheck-github-actions/steps.json New snap-test steps setting GITHUB_ACTIONS=true and running vp check.
packages/cli/snap-tests/check-pass-typecheck-github-actions/src/index.js New minimal source file for the snap-test fixture.
packages/cli/snap-tests/check-pass-typecheck-github-actions/snap.txt Expected snapshot output for the GitHub Actions scenario.
packages/cli/snap-tests/check-pass-typecheck-github-actions/package.json New snap-test fixture package manifest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fengmk2 fengmk2 merged commit d27d87d into voidzero-dev:main Mar 16, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error: Linting could not start

3 participants