fix: hooks are not expanded recursively (one level deep, matching npm)

When `vt run test` triggers `pretest` as a hook, `pretest` itself does
not look for `prepretest`. This matches npm's behavior where lifecycle
hooks are always one level deep.

Implemented via an `expand_hooks: bool` flag on `PlanContext` that is
set to `false` when planning any hook script. Added `prepretest` to the
script-hooks test fixture to prove that `vt run test` correctly produces
[pretest, test, posttest] without `prepretest`, while `vt run pretest`
directly does expand `prepretest`.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: branchseer

crates/vite_task_plan/src/context.rs

@@ -48,6 +48,12 @@ pub struct PlanContext<'a> {
     /// The query that caused the current expansion.
     /// Used by the skip rule to detect and skip duplicate nested expansions.
     parent_query: Arc<TaskQuery>,
+
+    /// Whether pre/post hook scripts should be expanded for the current task.
+    ///
+    /// Set to `false` when planning a hook script itself, so that hooks are
+    /// never expanded more than one level deep (matching npm behavior).
+    expand_hooks: bool,
 }
 
 impl<'a> PlanContext<'a> {
@@ -70,6 +76,7 @@ impl<'a> PlanContext<'a> {
             extra_args: Arc::default(),
             resolved_global_cache,
             parent_query,
+            expand_hooks: true,
         }
     }
 
@@ -150,6 +157,14 @@ impl<'a> PlanContext<'a> {
         self.task_call_stack.last().map(|(idx, _)| *idx)
     }
 
+    pub const fn expand_hooks(&self) -> bool {
+        self.expand_hooks
+    }
+
+    pub const fn set_expand_hooks(&mut self, expand_hooks: bool) {
+        self.expand_hooks = expand_hooks;
+    }
+
     pub fn duplicate(&mut self) -> PlanContext<'_> {
         PlanContext {
             workspace_path: self.workspace_path,
@@ -161,6 +176,7 @@ impl<'a> PlanContext<'a> {
             extra_args: Arc::clone(&self.extra_args),
             resolved_global_cache: self.resolved_global_cache,
             parent_query: Arc::clone(&self.parent_query),
+            expand_hooks: self.expand_hooks,
         }
     }
 }

crates/vite_task_plan/src/plan.rs

@@ -101,8 +101,11 @@ async fn plan_task_as_execution_node(
     let mut items = Vec::<ExecutionItem>::new();
 
     // Expand pre/post hooks (`preX`/`postX`) for package.json scripts.
+    // Hooks are never expanded more than one level deep (matching npm behavior): when planning a
+    // hook script, `expand_hooks` is false so it won't look for its own pre/post hooks.
     // Resolve the flag once before any mutable borrow of `context` (duplicate() needs &mut).
-    let pre_post_scripts_enabled = context.indexed_task_graph().pre_post_scripts_enabled();
+    let pre_post_scripts_enabled =
+        context.expand_hooks() && context.indexed_task_graph().pre_post_scripts_enabled();
     let pre_hook_idx = if pre_post_scripts_enabled {
         context.indexed_task_graph().get_script_hook(task_node_index, "pre")
     } else {
@@ -112,6 +115,7 @@ async fn plan_task_as_execution_node(
         let mut pre_context = context.duplicate();
         // Extra args (e.g. `vt run test --coverage`) must not be forwarded to hooks.
         pre_context.set_extra_args(Arc::new([]));
+        pre_context.set_expand_hooks(false);
         let pre_execution =
             Box::pin(plan_task_as_execution_node(pre_hook_idx, pre_context)).await?;
         items.extend(pre_execution.items);
@@ -384,6 +388,7 @@ async fn plan_task_as_execution_node(
         let mut post_context = context.duplicate();
         // Extra args must not be forwarded to hooks.
         post_context.set_extra_args(Arc::new([]));
+        post_context.set_expand_hooks(false);
         let post_execution =
             Box::pin(plan_task_as_execution_node(post_hook_idx, post_context)).await?;
         items.extend(post_execution.items);

crates/vite_task_plan/tests/plan_snapshots/fixtures/script-hooks/package.json

@@ -1,6 +1,7 @@
 {
   "name": "@test/script-hooks",
   "scripts": {
+    "prepretest": "echo prepretest",
     "pretest": "echo pretest",
     "test": "echo test",
     "posttest": "echo posttest",

crates/vite_task_plan/tests/plan_snapshots/fixtures/script-hooks/snapshots.toml

@@ -9,7 +9,7 @@ name = "build runs with pre hook only"
 args = ["run", "build"]
 
 [[plan]]
-name = "pretest directly has no hooks"
+name = "pretest directly expands prepretest but not when called as hook"
 args = ["run", "pretest"]
 
 [[plan]]

…ery - pretest directly has no hooks.snap …pretest but not when called as hook.snapcrates/vite_task_plan/tests/plan_snapshots/fixtures/script-hooks/snapshots/query - pretest directly has no hooks.snap renamed to crates/vite_task_plan/tests/plan_snapshots/fixtures/script-hooks/snapshots/query - pretest directly expands prepretest but not when called as hook.snap crates/vite_task_plan/tests/plan_snapshots/fixtures/script-hooks/snapshots/query - pretest directly has no hooks.snap renamed to crates/vite_task_plan/tests/plan_snapshots/fixtures/script-hooks/snapshots/query - pretest directly expands prepretest but not when called as hook.snap

@@ -20,6 +20,32 @@ input_file: crates/vite_task_plan/tests/plan_snapshots/fixtures/script-hooks
         "package_path": "<workspace>/"
       },
       "items": [
+        {
+          "execution_item_display": {
+            "task_display": {
+              "package_name": "@test/script-hooks",
+              "task_name": "prepretest",
+              "package_path": "<workspace>/"
+            },
+            "command": "echo prepretest",
+            "and_item_index": null,
+            "cwd": "<workspace>/"
+          },
+          "kind": {
+            "Leaf": {
+              "InProcess": {
+                "kind": {
+                  "Echo": {
+                    "strings": [
+                      "prepretest"
+                    ],
+                    "trailing_newline": true
+                  }
+                }
+              }
+            }
+          }
+        },
         {
           "execution_item_display": {
             "task_display": {

crates/vite_task_plan/tests/plan_snapshots/fixtures/script-hooks/snapshots/task graph.snap

@@ -106,6 +106,40 @@ input_file: crates/vite_task_plan/tests/plan_snapshots/fixtures/script-hooks
     },
     "neighbors": []
   },
+  {
+    "key": [
+      "<workspace>/",
+      "prepretest"
+    ],
+    "node": {
+      "task_display": {
+        "package_name": "@test/script-hooks",
+        "task_name": "prepretest",
+        "package_path": "<workspace>/"
+      },
+      "resolved_config": {
+        "command": "echo prepretest",
+        "resolved_options": {
+          "cwd": "<workspace>/",
+          "cache_config": {
+            "env_config": {
+              "fingerprinted_envs": [],
+              "untracked_env": [
+                "<default untracked envs>"
+              ]
+            },
+            "input_config": {
+              "includes_auto": true,
+              "positive_globs": [],
+              "negative_globs": []
+            }
+          }
+        }
+      },
+      "source": "PackageJsonScript"
+    },
+    "neighbors": []
+  },
   {
     "key": [
       "<workspace>/",